Lines Matching full:review
1 Code Review Guidelines
21 Overview of the code review process
34 - At least one ``Code-Owner-Review+1`` up-vote, and no ``Code-Owner-Review-1``
37 - At least one ``Maintainer-Review+1`` up-vote, and no ``Maintainer-Review-1``
50 To ensure the code review gives the greatest possible benefit, participants in
58 - Review other people's patches where possible. The more active reviewers there
60 code review helps everyone in the long run, as it creates a culture of
70 - Answer all comments from people who took the time to review your
77 In the event that a code review takes longer than you would hope for, you
97 - It is the patch-author's responsibility to respond to review comments within
101 responding to active review comments after posting patch(es). In such a
103 their work for review by resolving comments, merge-conflicts, and revising
109 There are no good or bad review comments. If you have any doubt about a patch or
111 issue slip. Examples of review comments could be:
157 through the ``Code-Owner-Review+1`` label in Gerrit. If instead, they have
159 ``Code-Owner-Review-1``.
164 - Once you are engaged in a review, make sure you stay involved until the patch
166 expected to monitor the patch author's answers to your review comments,
167 answer back if needed and review new revisions of their patch.
232 - Before merging a patch, verify that all review comments have been addressed.
237 through the ``Maintainer-Review+1`` label in Gerrit. If instead, they have
239 ``Maintainer-Review-1``.