1 //===- ARMSLSHardening.cpp - Harden Straight Line Missspeculation ---------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 //
9 // This file contains a pass to insert code to mitigate against side channel
10 // vulnerabilities that may happen under straight line miss-speculation.
11 //
12 //===----------------------------------------------------------------------===//
13
14 #include "ARM.h"
15 #include "ARMInstrInfo.h"
16 #include "ARMSubtarget.h"
17 #include "llvm/CodeGen/IndirectThunks.h"
18 #include "llvm/CodeGen/MachineBasicBlock.h"
19 #include "llvm/CodeGen/MachineFunction.h"
20 #include "llvm/CodeGen/MachineFunctionPass.h"
21 #include "llvm/CodeGen/MachineInstr.h"
22 #include "llvm/CodeGen/MachineInstrBuilder.h"
23 #include "llvm/CodeGen/MachineOperand.h"
24 #include "llvm/IR/DebugLoc.h"
25 #include <cassert>
26
27 using namespace llvm;
28
29 #define DEBUG_TYPE "arm-sls-hardening"
30
31 #define ARM_SLS_HARDENING_NAME "ARM sls hardening pass"
32
33 namespace {
34
35 class ARMSLSHardening : public MachineFunctionPass {
36 public:
37 const TargetInstrInfo *TII;
38 const ARMSubtarget *ST;
39
40 static char ID;
41
ARMSLSHardening()42 ARMSLSHardening() : MachineFunctionPass(ID) {
43 initializeARMSLSHardeningPass(*PassRegistry::getPassRegistry());
44 }
45
46 bool runOnMachineFunction(MachineFunction &Fn) override;
47
getPassName() const48 StringRef getPassName() const override { return ARM_SLS_HARDENING_NAME; }
49
getAnalysisUsage(AnalysisUsage & AU) const50 void getAnalysisUsage(AnalysisUsage &AU) const override {
51 AU.setPreservesCFG();
52 MachineFunctionPass::getAnalysisUsage(AU);
53 }
54
55 private:
56 bool hardenReturnsAndBRs(MachineBasicBlock &MBB) const;
57 bool hardenIndirectCalls(MachineBasicBlock &MBB) const;
58 MachineBasicBlock &
59 ConvertIndirectCallToIndirectJump(MachineBasicBlock &MBB,
60 MachineBasicBlock::iterator) const;
61 };
62
63 } // end anonymous namespace
64
65 char ARMSLSHardening::ID = 0;
66
67 INITIALIZE_PASS(ARMSLSHardening, "arm-sls-hardening",
68 ARM_SLS_HARDENING_NAME, false, false)
69
insertSpeculationBarrier(const ARMSubtarget * ST,MachineBasicBlock & MBB,MachineBasicBlock::iterator MBBI,DebugLoc DL,bool AlwaysUseISBDSB=false)70 static void insertSpeculationBarrier(const ARMSubtarget *ST,
71 MachineBasicBlock &MBB,
72 MachineBasicBlock::iterator MBBI,
73 DebugLoc DL,
74 bool AlwaysUseISBDSB = false) {
75 assert(MBBI != MBB.begin() &&
76 "Must not insert SpeculationBarrierEndBB as only instruction in MBB.");
77 assert(std::prev(MBBI)->isBarrier() &&
78 "SpeculationBarrierEndBB must only follow unconditional control flow "
79 "instructions.");
80 assert(std::prev(MBBI)->isTerminator() &&
81 "SpeculationBarrierEndBB must only follow terminators.");
82 const TargetInstrInfo *TII = ST->getInstrInfo();
83 assert(ST->hasDataBarrier() || ST->hasSB());
84 bool ProduceSB = ST->hasSB() && !AlwaysUseISBDSB;
85 unsigned BarrierOpc =
86 ProduceSB ? (ST->isThumb() ? ARM::t2SpeculationBarrierSBEndBB
87 : ARM::SpeculationBarrierSBEndBB)
88 : (ST->isThumb() ? ARM::t2SpeculationBarrierISBDSBEndBB
89 : ARM::SpeculationBarrierISBDSBEndBB);
90 if (MBBI == MBB.end() || !isSpeculationBarrierEndBBOpcode(MBBI->getOpcode()))
91 BuildMI(MBB, MBBI, DL, TII->get(BarrierOpc));
92 }
93
runOnMachineFunction(MachineFunction & MF)94 bool ARMSLSHardening::runOnMachineFunction(MachineFunction &MF) {
95 ST = &MF.getSubtarget<ARMSubtarget>();
96 TII = MF.getSubtarget().getInstrInfo();
97
98 bool Modified = false;
99 for (auto &MBB : MF) {
100 Modified |= hardenReturnsAndBRs(MBB);
101 Modified |= hardenIndirectCalls(MBB);
102 }
103
104 return Modified;
105 }
106
hardenReturnsAndBRs(MachineBasicBlock & MBB) const107 bool ARMSLSHardening::hardenReturnsAndBRs(MachineBasicBlock &MBB) const {
108 if (!ST->hardenSlsRetBr())
109 return false;
110 assert(!ST->isThumb1Only());
111 bool Modified = false;
112 MachineBasicBlock::iterator MBBI = MBB.getFirstTerminator(), E = MBB.end();
113 MachineBasicBlock::iterator NextMBBI;
114 for (; MBBI != E; MBBI = NextMBBI) {
115 MachineInstr &MI = *MBBI;
116 NextMBBI = std::next(MBBI);
117 if (isIndirectControlFlowNotComingBack(MI)) {
118 assert(MI.isTerminator());
119 assert(!TII->isPredicated(MI));
120 insertSpeculationBarrier(ST, MBB, std::next(MBBI), MI.getDebugLoc());
121 Modified = true;
122 }
123 }
124 return Modified;
125 }
126
127 static const char SLSBLRNamePrefix[] = "__llvm_slsblr_thunk_";
128
129 static const struct ThunkNameRegMode {
130 const char* Name;
131 Register Reg;
132 bool isThumb;
133 } SLSBLRThunks[] = {
134 {"__llvm_slsblr_thunk_arm_r0", ARM::R0, false},
135 {"__llvm_slsblr_thunk_arm_r1", ARM::R1, false},
136 {"__llvm_slsblr_thunk_arm_r2", ARM::R2, false},
137 {"__llvm_slsblr_thunk_arm_r3", ARM::R3, false},
138 {"__llvm_slsblr_thunk_arm_r4", ARM::R4, false},
139 {"__llvm_slsblr_thunk_arm_r5", ARM::R5, false},
140 {"__llvm_slsblr_thunk_arm_r6", ARM::R6, false},
141 {"__llvm_slsblr_thunk_arm_r7", ARM::R7, false},
142 {"__llvm_slsblr_thunk_arm_r8", ARM::R8, false},
143 {"__llvm_slsblr_thunk_arm_r9", ARM::R9, false},
144 {"__llvm_slsblr_thunk_arm_r10", ARM::R10, false},
145 {"__llvm_slsblr_thunk_arm_r11", ARM::R11, false},
146 {"__llvm_slsblr_thunk_arm_sp", ARM::SP, false},
147 {"__llvm_slsblr_thunk_arm_pc", ARM::PC, false},
148 {"__llvm_slsblr_thunk_thumb_r0", ARM::R0, true},
149 {"__llvm_slsblr_thunk_thumb_r1", ARM::R1, true},
150 {"__llvm_slsblr_thunk_thumb_r2", ARM::R2, true},
151 {"__llvm_slsblr_thunk_thumb_r3", ARM::R3, true},
152 {"__llvm_slsblr_thunk_thumb_r4", ARM::R4, true},
153 {"__llvm_slsblr_thunk_thumb_r5", ARM::R5, true},
154 {"__llvm_slsblr_thunk_thumb_r6", ARM::R6, true},
155 {"__llvm_slsblr_thunk_thumb_r7", ARM::R7, true},
156 {"__llvm_slsblr_thunk_thumb_r8", ARM::R8, true},
157 {"__llvm_slsblr_thunk_thumb_r9", ARM::R9, true},
158 {"__llvm_slsblr_thunk_thumb_r10", ARM::R10, true},
159 {"__llvm_slsblr_thunk_thumb_r11", ARM::R11, true},
160 {"__llvm_slsblr_thunk_thumb_sp", ARM::SP, true},
161 {"__llvm_slsblr_thunk_thumb_pc", ARM::PC, true},
162 };
163
164 // An enum for tracking whether Arm and Thumb thunks have been inserted into the
165 // current module so far.
166 enum ArmInsertedThunks { ArmThunk = 1, ThumbThunk = 2 };
167
operator |=(ArmInsertedThunks & X,ArmInsertedThunks Y)168 inline ArmInsertedThunks &operator|=(ArmInsertedThunks &X,
169 ArmInsertedThunks Y) {
170 return X = static_cast<ArmInsertedThunks>(X | Y);
171 }
172
173 namespace {
174 struct SLSBLRThunkInserter
175 : ThunkInserter<SLSBLRThunkInserter, ArmInsertedThunks> {
getThunkPrefix__anonfac7b5f70211::SLSBLRThunkInserter176 const char *getThunkPrefix() { return SLSBLRNamePrefix; }
mayUseThunk__anonfac7b5f70211::SLSBLRThunkInserter177 bool mayUseThunk(const MachineFunction &MF,
178 ArmInsertedThunks InsertedThunks) {
179 if ((InsertedThunks & ArmThunk &&
180 !MF.getSubtarget<ARMSubtarget>().isThumb()) ||
181 (InsertedThunks & ThumbThunk &&
182 MF.getSubtarget<ARMSubtarget>().isThumb()))
183 return false;
184 ComdatThunks &= !MF.getSubtarget<ARMSubtarget>().hardenSlsNoComdat();
185 // FIXME: This could also check if there are any indirect calls in the
186 // function to more accurately reflect if a thunk will be needed.
187 return MF.getSubtarget<ARMSubtarget>().hardenSlsBlr();
188 }
189 ArmInsertedThunks insertThunks(MachineModuleInfo &MMI, MachineFunction &MF);
190 void populateThunk(MachineFunction &MF);
191
192 private:
193 bool ComdatThunks = true;
194 };
195 } // namespace
196
insertThunks(MachineModuleInfo & MMI,MachineFunction & MF)197 ArmInsertedThunks SLSBLRThunkInserter::insertThunks(MachineModuleInfo &MMI,
198 MachineFunction &MF) {
199 // FIXME: It probably would be possible to filter which thunks to produce
200 // based on which registers are actually used in indirect calls in this
201 // function. But would that be a worthwhile optimization?
202 const ARMSubtarget *ST = &MF.getSubtarget<ARMSubtarget>();
203 for (auto T : SLSBLRThunks)
204 if (ST->isThumb() == T.isThumb)
205 createThunkFunction(MMI, T.Name, ComdatThunks);
206 return ST->isThumb() ? ThumbThunk : ArmThunk;
207 }
208
populateThunk(MachineFunction & MF)209 void SLSBLRThunkInserter::populateThunk(MachineFunction &MF) {
210 // FIXME: How to better communicate Register number, rather than through
211 // name and lookup table?
212 assert(MF.getName().startswith(getThunkPrefix()));
213 auto ThunkIt = llvm::find_if(
214 SLSBLRThunks, [&MF](auto T) { return T.Name == MF.getName(); });
215 assert(ThunkIt != std::end(SLSBLRThunks));
216 Register ThunkReg = ThunkIt->Reg;
217 bool isThumb = ThunkIt->isThumb;
218
219 const TargetInstrInfo *TII = MF.getSubtarget<ARMSubtarget>().getInstrInfo();
220 MachineBasicBlock *Entry = &MF.front();
221 Entry->clear();
222
223 // These thunks need to consist of the following instructions:
224 // __llvm_slsblr_thunk_(arm/thumb)_rN:
225 // bx rN
226 // barrierInsts
227 Entry->addLiveIn(ThunkReg);
228 if (isThumb)
229 BuildMI(Entry, DebugLoc(), TII->get(ARM::tBX))
230 .addReg(ThunkReg)
231 .add(predOps(ARMCC::AL));
232 else
233 BuildMI(Entry, DebugLoc(), TII->get(ARM::BX))
234 .addReg(ThunkReg);
235
236 // Make sure the thunks do not make use of the SB extension in case there is
237 // a function somewhere that will call to it that for some reason disabled
238 // the SB extension locally on that function, even though it's enabled for
239 // the module otherwise. Therefore set AlwaysUseISBSDB to true.
240 insertSpeculationBarrier(&MF.getSubtarget<ARMSubtarget>(), *Entry,
241 Entry->end(), DebugLoc(), true /*AlwaysUseISBDSB*/);
242 }
243
ConvertIndirectCallToIndirectJump(MachineBasicBlock & MBB,MachineBasicBlock::iterator MBBI) const244 MachineBasicBlock &ARMSLSHardening::ConvertIndirectCallToIndirectJump(
245 MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI) const {
246 // Transform an indirect call to an indirect jump as follows:
247 // Before:
248 // |-----------------------------|
249 // | ... |
250 // | instI |
251 // | BLX rN |
252 // | instJ |
253 // | ... |
254 // |-----------------------------|
255 //
256 // After:
257 // |---------- -------------------------|
258 // | ... |
259 // | instI |
260 // | *call* __llvm_slsblr_thunk_mode_xN |
261 // | instJ |
262 // | ... |
263 // |--------------------------------------|
264 //
265 // __llvm_slsblr_thunk_mode_xN:
266 // |-----------------------------|
267 // | BX rN |
268 // | barrierInsts |
269 // |-----------------------------|
270 //
271 // The __llvm_slsblr_thunk_mode_xN thunks are created by the
272 // SLSBLRThunkInserter.
273 // This function merely needs to transform an indirect call to a direct call
274 // to __llvm_slsblr_thunk_xN.
275 MachineInstr &IndirectCall = *MBBI;
276 assert(isIndirectCall(IndirectCall) && !IndirectCall.isReturn());
277 int RegOpIdxOnIndirectCall = -1;
278 bool isThumb;
279 switch (IndirectCall.getOpcode()) {
280 case ARM::BLX: // !isThumb2
281 case ARM::BLX_noip: // !isThumb2
282 isThumb = false;
283 RegOpIdxOnIndirectCall = 0;
284 break;
285 case ARM::tBLXr: // isThumb2
286 case ARM::tBLXr_noip: // isThumb2
287 isThumb = true;
288 RegOpIdxOnIndirectCall = 2;
289 break;
290 default:
291 llvm_unreachable("unhandled Indirect Call");
292 }
293
294 Register Reg = IndirectCall.getOperand(RegOpIdxOnIndirectCall).getReg();
295 // Since linkers are allowed to clobber R12 on function calls, the above
296 // mitigation only works if the original indirect call instruction was not
297 // using R12. Code generation before must make sure that no indirect call
298 // using R12 was produced if the mitigation is enabled.
299 // Also, the transformation is incorrect if the indirect call uses LR, so
300 // also have to avoid that.
301 assert(Reg != ARM::R12 && Reg != ARM::LR);
302 bool RegIsKilled = IndirectCall.getOperand(RegOpIdxOnIndirectCall).isKill();
303
304 DebugLoc DL = IndirectCall.getDebugLoc();
305
306 MachineFunction &MF = *MBBI->getMF();
307 auto ThunkIt = llvm::find_if(SLSBLRThunks, [Reg, isThumb](auto T) {
308 return T.Reg == Reg && T.isThumb == isThumb;
309 });
310 assert(ThunkIt != std::end(SLSBLRThunks));
311 Module *M = MF.getFunction().getParent();
312 const GlobalValue *GV = cast<GlobalValue>(M->getNamedValue(ThunkIt->Name));
313
314 MachineInstr *BL =
315 isThumb ? BuildMI(MBB, MBBI, DL, TII->get(ARM::tBL))
316 .addImm(IndirectCall.getOperand(0).getImm())
317 .addReg(IndirectCall.getOperand(1).getReg())
318 .addGlobalAddress(GV)
319 : BuildMI(MBB, MBBI, DL, TII->get(ARM::BL)).addGlobalAddress(GV);
320
321 // Now copy the implicit operands from IndirectCall to BL and copy other
322 // necessary info.
323 // However, both IndirectCall and BL instructions implictly use SP and
324 // implicitly define LR. Blindly copying implicit operands would result in SP
325 // and LR operands to be present multiple times. While this may not be too
326 // much of an issue, let's avoid that for cleanliness, by removing those
327 // implicit operands from the BL created above before we copy over all
328 // implicit operands from the IndirectCall.
329 int ImpLROpIdx = -1;
330 int ImpSPOpIdx = -1;
331 for (unsigned OpIdx = BL->getNumExplicitOperands();
332 OpIdx < BL->getNumOperands(); OpIdx++) {
333 MachineOperand Op = BL->getOperand(OpIdx);
334 if (!Op.isReg())
335 continue;
336 if (Op.getReg() == ARM::LR && Op.isDef())
337 ImpLROpIdx = OpIdx;
338 if (Op.getReg() == ARM::SP && !Op.isDef())
339 ImpSPOpIdx = OpIdx;
340 }
341 assert(ImpLROpIdx != -1);
342 assert(ImpSPOpIdx != -1);
343 int FirstOpIdxToRemove = std::max(ImpLROpIdx, ImpSPOpIdx);
344 int SecondOpIdxToRemove = std::min(ImpLROpIdx, ImpSPOpIdx);
345 BL->removeOperand(FirstOpIdxToRemove);
346 BL->removeOperand(SecondOpIdxToRemove);
347 // Now copy over the implicit operands from the original IndirectCall
348 BL->copyImplicitOps(MF, IndirectCall);
349 MF.moveCallSiteInfo(&IndirectCall, BL);
350 // Also add the register called in the IndirectCall as being used in the
351 // called thunk.
352 BL->addOperand(MachineOperand::CreateReg(Reg, false /*isDef*/, true /*isImp*/,
353 RegIsKilled /*isKill*/));
354 // Remove IndirectCallinstruction
355 MBB.erase(MBBI);
356 return MBB;
357 }
358
hardenIndirectCalls(MachineBasicBlock & MBB) const359 bool ARMSLSHardening::hardenIndirectCalls(MachineBasicBlock &MBB) const {
360 if (!ST->hardenSlsBlr())
361 return false;
362 bool Modified = false;
363 MachineBasicBlock::iterator MBBI = MBB.begin(), E = MBB.end();
364 MachineBasicBlock::iterator NextMBBI;
365 for (; MBBI != E; MBBI = NextMBBI) {
366 MachineInstr &MI = *MBBI;
367 NextMBBI = std::next(MBBI);
368 // Tail calls are both indirect calls and "returns".
369 // They are also indirect jumps, so should be handled by sls-harden-retbr,
370 // rather than sls-harden-blr.
371 if (isIndirectCall(MI) && !MI.isReturn()) {
372 ConvertIndirectCallToIndirectJump(MBB, MBBI);
373 Modified = true;
374 }
375 }
376 return Modified;
377 }
378
379
380
createARMSLSHardeningPass()381 FunctionPass *llvm::createARMSLSHardeningPass() {
382 return new ARMSLSHardening();
383 }
384
385 namespace {
386 class ARMIndirectThunks : public MachineFunctionPass {
387 public:
388 static char ID;
389
ARMIndirectThunks()390 ARMIndirectThunks() : MachineFunctionPass(ID) {}
391
getPassName() const392 StringRef getPassName() const override { return "ARM Indirect Thunks"; }
393
394 bool doInitialization(Module &M) override;
395 bool runOnMachineFunction(MachineFunction &MF) override;
396
getAnalysisUsage(AnalysisUsage & AU) const397 void getAnalysisUsage(AnalysisUsage &AU) const override {
398 MachineFunctionPass::getAnalysisUsage(AU);
399 AU.addRequired<MachineModuleInfoWrapperPass>();
400 AU.addPreserved<MachineModuleInfoWrapperPass>();
401 }
402
403 private:
404 std::tuple<SLSBLRThunkInserter> TIs;
405
406 // FIXME: When LLVM moves to C++17, these can become folds
407 template <typename... ThunkInserterT>
initTIs(Module & M,std::tuple<ThunkInserterT...> & ThunkInserters)408 static void initTIs(Module &M,
409 std::tuple<ThunkInserterT...> &ThunkInserters) {
410 (void)std::initializer_list<int>{
411 (std::get<ThunkInserterT>(ThunkInserters).init(M), 0)...};
412 }
413 template <typename... ThunkInserterT>
runTIs(MachineModuleInfo & MMI,MachineFunction & MF,std::tuple<ThunkInserterT...> & ThunkInserters)414 static bool runTIs(MachineModuleInfo &MMI, MachineFunction &MF,
415 std::tuple<ThunkInserterT...> &ThunkInserters) {
416 bool Modified = false;
417 (void)std::initializer_list<int>{
418 Modified |= std::get<ThunkInserterT>(ThunkInserters).run(MMI, MF)...};
419 return Modified;
420 }
421 };
422
423 } // end anonymous namespace
424
425 char ARMIndirectThunks::ID = 0;
426
createARMIndirectThunks()427 FunctionPass *llvm::createARMIndirectThunks() {
428 return new ARMIndirectThunks();
429 }
430
doInitialization(Module & M)431 bool ARMIndirectThunks::doInitialization(Module &M) {
432 initTIs(M, TIs);
433 return false;
434 }
435
runOnMachineFunction(MachineFunction & MF)436 bool ARMIndirectThunks::runOnMachineFunction(MachineFunction &MF) {
437 LLVM_DEBUG(dbgs() << getPassName() << '\n');
438 auto &MMI = getAnalysis<MachineModuleInfoWrapperPass>().getMMI();
439 return runTIs(MMI, MF, TIs);
440 }
441