xref: /aosp_15_r20/external/mesa3d/src/gallium/drivers/llvmpipe/lp_scene.c (revision 6104692788411f58d303aa86923a9ff6ecaded22)
1 /**************************************************************************
2  *
3  * Copyright 2009 VMware, Inc.
4  * All Rights Reserved.
5  *
6  * Permission is hereby granted, free of charge, to any person obtaining a
7  * copy of this software and associated documentation files (the
8  * "Software"), to deal in the Software without restriction, including
9  * without limitation the rights to use, copy, modify, merge, publish,
10  * distribute, sub license, and/or sell copies of the Software, and to
11  * permit persons to whom the Software is furnished to do so, subject to
12  * the following conditions:
13  *
14  * The above copyright notice and this permission notice (including the
15  * next paragraph) shall be included in all copies or substantial portions
16  * of the Software.
17  *
18  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
19  * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
20  * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
21  * IN NO EVENT SHALL VMWARE AND/OR ITS SUPPLIERS BE LIABLE FOR
22  * ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
23  * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
24  * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
25  *
26  **************************************************************************/
27 
28 #include "util/u_framebuffer.h"
29 #include "util/u_math.h"
30 #include "util/u_memory.h"
31 #include "util/reallocarray.h"
32 #include "util/u_inlines.h"
33 #include "util/format/u_format.h"
34 #include "lp_scene.h"
35 #include "lp_fence.h"
36 #include "lp_debug.h"
37 #include "lp_context.h"
38 #include "lp_state_fs.h"
39 #include "lp_setup_context.h"
40 
41 
42 #define RESOURCE_REF_SZ 32
43 /** List of resource references */
44 struct resource_ref {
45    struct pipe_resource *resource[RESOURCE_REF_SZ];
46    int count;
47    struct resource_ref *next;
48 };
49 
50 
51 #define SHADER_REF_SZ 32
52 /** List of shader variant references */
53 struct shader_ref {
54    struct lp_fragment_shader_variant *variant[SHADER_REF_SZ];
55    int count;
56    struct shader_ref *next;
57 };
58 
59 
60 /**
61  * Create a new scene object.
62  * \param queue  the queue to put newly rendered/emptied scenes into
63  */
64 struct lp_scene *
lp_scene_create(struct lp_setup_context * setup)65 lp_scene_create(struct lp_setup_context *setup)
66 {
67    struct lp_scene *scene = slab_alloc_st(&setup->scene_slab);
68    if (!scene)
69       return NULL;
70 
71    memset(scene, 0, sizeof(struct lp_scene));
72    scene->pipe = setup->pipe;
73    scene->setup = setup;
74    scene->data.head = &scene->data.first;
75 
76    (void) mtx_init(&scene->mutex, mtx_plain);
77 
78 #if MESA_DEBUG
79    /* Do some scene limit sanity checks here */
80    {
81       size_t maxBins = TILES_X * TILES_Y;
82       size_t maxCommandBytes = sizeof(struct cmd_block) * maxBins;
83       size_t maxCommandPlusData = maxCommandBytes + DATA_BLOCK_SIZE;
84       /* We'll need at least one command block per bin.  Make sure that's
85        * less than the max allowed scene size.
86        */
87       assert(maxCommandBytes < LP_SCENE_MAX_SIZE);
88       /* We'll also need space for at least one other data block */
89       assert(maxCommandPlusData <= LP_SCENE_MAX_SIZE);
90    }
91 #endif
92 
93    return scene;
94 }
95 
96 
97 /**
98  * Free all data associated with the given scene, and the scene itself.
99  */
100 void
lp_scene_destroy(struct lp_scene * scene)101 lp_scene_destroy(struct lp_scene *scene)
102 {
103    lp_scene_end_rasterization(scene);
104    mtx_destroy(&scene->mutex);
105    free(scene->tiles);
106    assert(scene->data.head == &scene->data.first);
107    slab_free_st(&scene->setup->scene_slab, scene);
108 }
109 
110 
111 /**
112  * Check if the scene's bins are all empty.
113  * For debugging purposes.
114  */
115 bool
lp_scene_is_empty(struct lp_scene * scene)116 lp_scene_is_empty(struct lp_scene *scene)
117 {
118    for (unsigned y = 0; y < scene->tiles_y; y++) {
119       for (unsigned x = 0; x < scene->tiles_x; x++) {
120          const struct cmd_bin *bin = lp_scene_get_bin(scene, x, y);
121          if (bin->head) {
122             return false;
123          }
124       }
125    }
126    return true;
127 }
128 
129 
130 /* Returns true if there has ever been a failed allocation attempt in
131  * this scene.  Used in triangle/rectangle emit to avoid having to
132  * check success at each bin.
133  */
134 bool
lp_scene_is_oom(struct lp_scene * scene)135 lp_scene_is_oom(struct lp_scene *scene)
136 {
137    return scene->alloc_failed;
138 }
139 
140 
141 /* Remove all commands from a bin.  Tries to reuse some of the memory
142  * allocated to the bin, however.
143  */
144 void
lp_scene_bin_reset(struct lp_scene * scene,unsigned x,unsigned y)145 lp_scene_bin_reset(struct lp_scene *scene, unsigned x, unsigned y)
146 {
147    struct cmd_bin *bin = lp_scene_get_bin(scene, x, y);
148 
149    bin->last_state = NULL;
150    bin->head = bin->tail;
151    if (bin->tail) {
152       bin->tail->next = NULL;
153       bin->tail->count = 0;
154    }
155 }
156 
157 
158 static void
init_scene_texture(struct lp_scene_surface * ssurf,struct pipe_surface * psurf)159 init_scene_texture(struct lp_scene_surface *ssurf, struct pipe_surface *psurf)
160 {
161    if (!psurf) {
162       ssurf->stride = 0;
163       ssurf->layer_stride = 0;
164       ssurf->sample_stride = 0;
165       ssurf->nr_samples = 0;
166       ssurf->map = NULL;
167       return;
168    }
169 
170    if (llvmpipe_resource_is_texture(psurf->texture)) {
171       ssurf->stride = llvmpipe_resource_stride(psurf->texture,
172                                                psurf->u.tex.level);
173       ssurf->layer_stride = llvmpipe_layer_stride(psurf->texture,
174                                                            psurf->u.tex.level);
175       ssurf->sample_stride = llvmpipe_sample_stride(psurf->texture);
176 
177       ssurf->map = llvmpipe_resource_map(psurf->texture,
178                                          psurf->u.tex.level,
179                                          psurf->u.tex.first_layer,
180                                          LP_TEX_USAGE_READ_WRITE);
181       ssurf->format_bytes = util_format_get_blocksize(psurf->format);
182       ssurf->nr_samples = util_res_sample_count(psurf->texture);
183    } else {
184       struct llvmpipe_resource *lpr = llvmpipe_resource(psurf->texture);
185       unsigned pixstride = util_format_get_blocksize(psurf->format);
186       ssurf->stride = psurf->texture->width0;
187       ssurf->layer_stride = 0;
188       ssurf->sample_stride = 0;
189       ssurf->nr_samples = 1;
190       ssurf->map = lpr->data;
191       ssurf->map += psurf->u.buf.first_element * pixstride;
192       ssurf->format_bytes = util_format_get_blocksize(psurf->format);
193    }
194 }
195 
196 
197 void
lp_scene_begin_rasterization(struct lp_scene * scene)198 lp_scene_begin_rasterization(struct lp_scene *scene)
199 {
200    const struct pipe_framebuffer_state *fb = &scene->fb;
201 
202    //LP_DBG(DEBUG_RAST, "%s\n", __func__);
203 
204    for (unsigned i = 0; i < scene->fb.nr_cbufs; i++) {
205       struct pipe_surface *cbuf = scene->fb.cbufs[i];
206       init_scene_texture(&scene->cbufs[i], cbuf);
207    }
208 
209    if (fb->zsbuf) {
210       struct pipe_surface *zsbuf = scene->fb.zsbuf;
211       init_scene_texture(&scene->zsbuf, zsbuf);
212    }
213 }
214 
215 
216 /**
217  * Free all the temporary data in a scene.
218  */
219 void
lp_scene_end_rasterization(struct lp_scene * scene)220 lp_scene_end_rasterization(struct lp_scene *scene)
221 {
222    mtx_lock(&scene->mutex);
223 
224    /* Unmap color buffers */
225    for (unsigned i = 0; i < scene->fb.nr_cbufs; i++) {
226       if (scene->cbufs[i].map) {
227          struct pipe_surface *cbuf = scene->fb.cbufs[i];
228          if (llvmpipe_resource_is_texture(cbuf->texture)) {
229             llvmpipe_resource_unmap(cbuf->texture,
230                                     cbuf->u.tex.level,
231                                     cbuf->u.tex.first_layer);
232          }
233          scene->cbufs[i].map = NULL;
234       }
235    }
236 
237    /* Unmap z/stencil buffer */
238    if (scene->zsbuf.map) {
239       struct pipe_surface *zsbuf = scene->fb.zsbuf;
240       llvmpipe_resource_unmap(zsbuf->texture,
241                               zsbuf->u.tex.level,
242                               zsbuf->u.tex.first_layer);
243       scene->zsbuf.map = NULL;
244    }
245 
246    /* Reset all command lists:
247     */
248    memset(scene->tiles, 0, sizeof(struct cmd_bin) * scene->num_alloced_tiles);
249 
250    /* Decrement texture ref counts
251     */
252    int j = 0;
253    for (struct resource_ref *ref = scene->resources; ref; ref = ref->next) {
254       for (int i = 0; i < ref->count; i++) {
255          if (LP_DEBUG & DEBUG_SETUP)
256             debug_printf("resource %d: %p %dx%d sz %d\n",
257                          j,
258                          (void *) ref->resource[i],
259                          ref->resource[i]->width0,
260                          ref->resource[i]->height0,
261                          llvmpipe_resource_size(ref->resource[i]));
262          j++;
263          llvmpipe_resource_unmap(ref->resource[i], 0, 0);
264          pipe_resource_reference(&ref->resource[i], NULL);
265       }
266    }
267 
268    for (struct resource_ref *ref = scene->writeable_resources; ref;
269         ref = ref->next) {
270       for (int i = 0; i < ref->count; i++) {
271          if (LP_DEBUG & DEBUG_SETUP)
272             debug_printf("resource %d: %p %dx%d sz %d\n",
273                          j,
274                          (void *) ref->resource[i],
275                          ref->resource[i]->width0,
276                             ref->resource[i]->height0,
277                          llvmpipe_resource_size(ref->resource[i]));
278          j++;
279          llvmpipe_resource_unmap(ref->resource[i], 0, 0);
280          pipe_resource_reference(&ref->resource[i], NULL);
281       }
282    }
283 
284    if (LP_DEBUG & DEBUG_SETUP) {
285       debug_printf("scene %d resources, sz %d\n",
286                    j, scene->resource_reference_size);
287    }
288 
289    /* Decrement shader variant ref counts
290     */
291    j = 0;
292    for (struct shader_ref *ref = scene->frag_shaders; ref; ref = ref->next) {
293       for (int i = 0; i < ref->count; i++) {
294          if (LP_DEBUG & DEBUG_SETUP)
295             debug_printf("shader %d: %p\n", j, (void *) ref->variant[i]);
296          j++;
297          lp_fs_variant_reference(llvmpipe_context(scene->pipe),
298                                  &ref->variant[i], NULL);
299       }
300    }
301 
302    /* Free all scene data blocks:
303     */
304    {
305       struct data_block_list *list = &scene->data;
306       struct data_block *block, *tmp;
307 
308       for (block = list->head; block; block = tmp) {
309          tmp = block->next;
310          if (block != &list->first)
311             FREE(block);
312       }
313 
314       list->head = &list->first;
315       list->head->next = NULL;
316    }
317 
318    lp_fence_reference(&scene->fence, NULL);
319 
320    scene->resources = NULL;
321    scene->writeable_resources = NULL;
322    scene->frag_shaders = NULL;
323    scene->scene_size = 0;
324    scene->resource_reference_size = 0;
325 
326    scene->alloc_failed = false;
327 
328    util_unreference_framebuffer_state(&scene->fb);
329 
330    mtx_unlock(&scene->mutex);
331 }
332 
333 
334 struct cmd_block *
lp_scene_new_cmd_block(struct lp_scene * scene,struct cmd_bin * bin)335 lp_scene_new_cmd_block(struct lp_scene *scene,
336                        struct cmd_bin *bin)
337 {
338    struct cmd_block *block = lp_scene_alloc(scene, sizeof(struct cmd_block));
339    if (block) {
340       if (bin->tail) {
341          bin->tail->next = block;
342          bin->tail = block;
343       } else {
344          bin->head = block;
345          bin->tail = block;
346       }
347       //memset(block, 0, sizeof *block);
348       block->next = NULL;
349       block->count = 0;
350    }
351    return block;
352 }
353 
354 
355 struct data_block *
lp_scene_new_data_block(struct lp_scene * scene)356 lp_scene_new_data_block(struct lp_scene *scene)
357 {
358    if (scene->scene_size + DATA_BLOCK_SIZE > LP_SCENE_MAX_SIZE) {
359       if (0) debug_printf("%s: failed\n", __func__);
360       scene->alloc_failed = true;
361       return NULL;
362    } else {
363       struct data_block *block = MALLOC_STRUCT(data_block);
364       if (!block)
365          return NULL;
366 
367       scene->scene_size += sizeof *block;
368 
369       block->used = 0;
370       block->next = scene->data.head;
371       scene->data.head = block;
372 
373       return block;
374    }
375 }
376 
377 
378 /**
379  * Return number of bytes used for all bin data within a scene.
380  * This does not include resources (textures) referenced by the scene.
381  */
382 static unsigned
lp_scene_data_size(const struct lp_scene * scene)383 lp_scene_data_size(const struct lp_scene *scene)
384 {
385    unsigned size = 0;
386    const struct data_block *block;
387    for (block = scene->data.head; block; block = block->next) {
388       size += block->used;
389    }
390    return size;
391 }
392 
393 
394 
395 /**
396  * Add a reference to a resource by the scene.
397  */
398 bool
lp_scene_add_resource_reference(struct lp_scene * scene,struct pipe_resource * resource,bool initializing_scene,bool writeable)399 lp_scene_add_resource_reference(struct lp_scene *scene,
400                                 struct pipe_resource *resource,
401                                 bool initializing_scene,
402                                 bool writeable)
403 {
404    struct resource_ref *ref;
405    int i;
406    struct resource_ref **list = writeable ? &scene->writeable_resources : &scene->resources;
407    struct resource_ref **last = list;
408 
409    mtx_lock(&scene->mutex);
410 
411    /* Look at existing resource blocks:
412     */
413    for (ref = *list; ref; ref = ref->next) {
414       last = &ref->next;
415 
416       /* Search for this resource:
417        */
418       for (i = 0; i < ref->count; i++)
419          if (ref->resource[i] == resource) {
420             mtx_unlock(&scene->mutex);
421             return true;
422       }
423 
424       if (ref->count < RESOURCE_REF_SZ) {
425          /* If the block is half-empty, then append the reference here.
426           */
427          break;
428       }
429    }
430 
431    /* Create a new block if no half-empty block was found.
432     */
433    if (!ref) {
434       assert(*last == NULL);
435       *last = lp_scene_alloc(scene, sizeof *ref);
436       if (*last == NULL) {
437           mtx_unlock(&scene->mutex);
438           return false;
439       }
440 
441       ref = *last;
442       memset(ref, 0, sizeof *ref);
443    }
444 
445    /* Map resource again to increment the map count. We likely use the
446     * already-mapped pointer in a texture of the jit context, and that pointer
447     * needs to stay mapped during rasterization. This map is unmap'ed when
448     * finalizing scene rasterization. */
449    llvmpipe_resource_map(resource, 0, 0, LP_TEX_USAGE_READ);
450 
451    /* Append the reference to the reference block.
452     */
453    pipe_resource_reference(&ref->resource[ref->count++], resource);
454    scene->resource_reference_size += llvmpipe_resource_size(resource);
455 
456    /* Heuristic to advise scene flushes.  This isn't helpful in the
457     * initial setup of the scene, but after that point flush on the
458     * next resource added which exceeds 64MB in referenced texture
459     * data.
460     */
461    int flush = (initializing_scene || scene->resource_reference_size < LP_SCENE_MAX_RESOURCE_SIZE);
462    mtx_unlock(&scene->mutex);
463    return flush;
464 }
465 
466 /**
467  * Add a reference to a fragment shader variant
468  * Return FALSE if out of memory, TRUE otherwise.
469  */
470 bool
lp_scene_add_frag_shader_reference(struct lp_scene * scene,struct lp_fragment_shader_variant * variant)471 lp_scene_add_frag_shader_reference(struct lp_scene *scene,
472                                    struct lp_fragment_shader_variant *variant)
473 {
474    struct shader_ref *ref, **last = &scene->frag_shaders;
475 
476    /* Look at existing resource blocks:
477     */
478    for (ref = scene->frag_shaders; ref; ref = ref->next) {
479       last = &ref->next;
480 
481       /* Search for this resource:
482        */
483       for (int i = 0; i < ref->count; i++)
484          if (ref->variant[i] == variant)
485             return true;
486 
487       if (ref->count < SHADER_REF_SZ) {
488          /* If the block is half-empty, then append the reference here.
489           */
490          break;
491       }
492    }
493 
494    /* Create a new block if no half-empty block was found.
495     */
496    if (!ref) {
497       assert(*last == NULL);
498       *last = lp_scene_alloc(scene, sizeof *ref);
499       if (*last == NULL)
500           return false;
501 
502       ref = *last;
503       memset(ref, 0, sizeof *ref);
504    }
505 
506    /* Append the reference to the reference block.
507     */
508    lp_fs_variant_reference(llvmpipe_context(scene->pipe),
509                            &ref->variant[ref->count++], variant);
510 
511    return true;
512 }
513 
514 
515 /**
516  * Does this scene have a reference to the given resource?
517  * Returns bitmask of LP_REFERENCED_FOR_READ/WRITE bits.
518  */
519 unsigned
lp_scene_is_resource_referenced(const struct lp_scene * scene,const struct pipe_resource * resource)520 lp_scene_is_resource_referenced(const struct lp_scene *scene,
521                                 const struct pipe_resource *resource)
522 {
523    const struct resource_ref *ref;
524 
525    /* check the render targets */
526    for (unsigned j = 0; j < scene->fb.nr_cbufs; j++) {
527      if (scene->fb.cbufs[j] && scene->fb.cbufs[j]->texture == resource)
528        return LP_REFERENCED_FOR_READ | LP_REFERENCED_FOR_WRITE;
529    }
530    if (scene->fb.zsbuf && scene->fb.zsbuf->texture == resource) {
531      return LP_REFERENCED_FOR_READ | LP_REFERENCED_FOR_WRITE;
532    }
533 
534    for (ref = scene->resources; ref; ref = ref->next) {
535       for (int i = 0; i < ref->count; i++)
536          if (ref->resource[i] == resource)
537             return LP_REFERENCED_FOR_READ;
538    }
539 
540    for (ref = scene->writeable_resources; ref; ref = ref->next) {
541       for (int i = 0; i < ref->count; i++)
542          if (ref->resource[i] == resource)
543             return LP_REFERENCED_FOR_READ | LP_REFERENCED_FOR_WRITE;
544    }
545 
546    return 0;
547 }
548 
549 
550 /** advance curr_x,y to the next bin */
551 static bool
next_bin(struct lp_scene * scene)552 next_bin(struct lp_scene *scene)
553 {
554    scene->curr_x++;
555    if (scene->curr_x >= scene->tiles_x) {
556       scene->curr_x = 0;
557       scene->curr_y++;
558    }
559    if (scene->curr_y >= scene->tiles_y) {
560       /* no more bins */
561       return false;
562    }
563    return true;
564 }
565 
566 
567 void
lp_scene_bin_iter_begin(struct lp_scene * scene)568 lp_scene_bin_iter_begin(struct lp_scene *scene)
569 {
570    scene->curr_x = scene->curr_y = -1;
571 }
572 
573 
574 /**
575  * Return pointer to next bin to be rendered.
576  * The lp_scene::curr_x and ::curr_y fields will be advanced.
577  * Multiple rendering threads will call this function to get a chunk
578  * of work (a bin) to work on.
579  */
580 struct cmd_bin *
lp_scene_bin_iter_next(struct lp_scene * scene,int * x,int * y)581 lp_scene_bin_iter_next(struct lp_scene *scene , int *x, int *y)
582 {
583    struct cmd_bin *bin = NULL;
584 
585    mtx_lock(&scene->mutex);
586 
587    if (scene->curr_x < 0) {
588       /* first bin */
589       scene->curr_x = 0;
590       scene->curr_y = 0;
591    } else if (!next_bin(scene)) {
592       /* no more bins left */
593       goto end;
594    }
595 
596    bin = lp_scene_get_bin(scene, scene->curr_x, scene->curr_y);
597    *x = scene->curr_x;
598    *y = scene->curr_y;
599 
600 end:
601    /*printf("return bin %p at %d, %d\n", (void *) bin, *bin_x, *bin_y);*/
602    mtx_unlock(&scene->mutex);
603    return bin;
604 }
605 
606 
607 void
lp_scene_begin_binning(struct lp_scene * scene,struct pipe_framebuffer_state * fb)608 lp_scene_begin_binning(struct lp_scene *scene,
609                        struct pipe_framebuffer_state *fb)
610 {
611    assert(lp_scene_is_empty(scene));
612 
613    util_copy_framebuffer_state(&scene->fb, fb);
614 
615    scene->tiles_x = align(fb->width, TILE_SIZE) / TILE_SIZE;
616    scene->tiles_y = align(fb->height, TILE_SIZE) / TILE_SIZE;
617    assert(scene->tiles_x <= TILES_X);
618    assert(scene->tiles_y <= TILES_Y);
619 
620    unsigned num_required_tiles = scene->tiles_x * scene->tiles_y;
621    if (scene->num_alloced_tiles < num_required_tiles) {
622       scene->tiles = reallocarray(scene->tiles, num_required_tiles,
623                                   sizeof(struct cmd_bin));
624       if (!scene->tiles)
625          return;
626       memset(scene->tiles, 0, sizeof(struct cmd_bin) * num_required_tiles);
627       scene->num_alloced_tiles = num_required_tiles;
628    }
629 
630    /*
631     * Determine how many layers the fb has (used for clamping layer value).
632     * OpenGL (but not d3d10) permits different amount of layers per rt,
633     * however results are undefined if layer exceeds the amount of layers of
634     * ANY attachment hence don't need separate per cbuf and zsbuf max.
635     */
636    unsigned max_layer = ~0;
637    for (unsigned i = 0; i < scene->fb.nr_cbufs; i++) {
638       struct pipe_surface *cbuf = scene->fb.cbufs[i];
639       if (cbuf) {
640          if (llvmpipe_resource_is_texture(cbuf->texture)) {
641             max_layer = MIN2(max_layer,
642                              cbuf->u.tex.last_layer - cbuf->u.tex.first_layer);
643          } else {
644             max_layer = 0;
645          }
646       }
647    }
648 
649    if (fb->zsbuf) {
650       struct pipe_surface *zsbuf = scene->fb.zsbuf;
651       max_layer = MIN2(max_layer, zsbuf->u.tex.last_layer - zsbuf->u.tex.first_layer);
652    }
653 
654    scene->fb_max_layer = max_layer;
655    scene->fb_max_samples = util_framebuffer_get_num_samples(fb);
656    if (scene->fb_max_samples == 4) {
657       for (unsigned i = 0; i < 4; i++) {
658          scene->fixed_sample_pos[i][0] = util_iround(lp_sample_pos_4x[i][0] * FIXED_ONE);
659          scene->fixed_sample_pos[i][1] = util_iround(lp_sample_pos_4x[i][1] * FIXED_ONE);
660       }
661    }
662 }
663 
664 
665 void
lp_scene_end_binning(struct lp_scene * scene)666 lp_scene_end_binning(struct lp_scene *scene)
667 {
668    if (LP_DEBUG & DEBUG_SCENE) {
669       debug_printf("rasterize scene:\n");
670       debug_printf("  scene_size: %u\n",
671                    scene->scene_size);
672       debug_printf("  data size: %u\n",
673                    lp_scene_data_size(scene));
674 
675       if (0)
676          lp_debug_bins(scene);
677    }
678 }
679