1*67e74705SXin Li //=== PointerSubChecker.cpp - Pointer subtraction checker ------*- C++ -*--===//
2*67e74705SXin Li //
3*67e74705SXin Li // The LLVM Compiler Infrastructure
4*67e74705SXin Li //
5*67e74705SXin Li // This file is distributed under the University of Illinois Open Source
6*67e74705SXin Li // License. See LICENSE.TXT for details.
7*67e74705SXin Li //
8*67e74705SXin Li //===----------------------------------------------------------------------===//
9*67e74705SXin Li //
10*67e74705SXin Li // This files defines PointerSubChecker, a builtin checker that checks for
11*67e74705SXin Li // pointer subtractions on two pointers pointing to different memory chunks.
12*67e74705SXin Li // This check corresponds to CWE-469.
13*67e74705SXin Li //
14*67e74705SXin Li //===----------------------------------------------------------------------===//
15*67e74705SXin Li
16*67e74705SXin Li #include "ClangSACheckers.h"
17*67e74705SXin Li #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
18*67e74705SXin Li #include "clang/StaticAnalyzer/Core/Checker.h"
19*67e74705SXin Li #include "clang/StaticAnalyzer/Core/CheckerManager.h"
20*67e74705SXin Li #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
21*67e74705SXin Li
22*67e74705SXin Li using namespace clang;
23*67e74705SXin Li using namespace ento;
24*67e74705SXin Li
25*67e74705SXin Li namespace {
26*67e74705SXin Li class PointerSubChecker
27*67e74705SXin Li : public Checker< check::PreStmt<BinaryOperator> > {
28*67e74705SXin Li mutable std::unique_ptr<BuiltinBug> BT;
29*67e74705SXin Li
30*67e74705SXin Li public:
31*67e74705SXin Li void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const;
32*67e74705SXin Li };
33*67e74705SXin Li }
34*67e74705SXin Li
checkPreStmt(const BinaryOperator * B,CheckerContext & C) const35*67e74705SXin Li void PointerSubChecker::checkPreStmt(const BinaryOperator *B,
36*67e74705SXin Li CheckerContext &C) const {
37*67e74705SXin Li // When doing pointer subtraction, if the two pointers do not point to the
38*67e74705SXin Li // same memory chunk, emit a warning.
39*67e74705SXin Li if (B->getOpcode() != BO_Sub)
40*67e74705SXin Li return;
41*67e74705SXin Li
42*67e74705SXin Li ProgramStateRef state = C.getState();
43*67e74705SXin Li const LocationContext *LCtx = C.getLocationContext();
44*67e74705SXin Li SVal LV = state->getSVal(B->getLHS(), LCtx);
45*67e74705SXin Li SVal RV = state->getSVal(B->getRHS(), LCtx);
46*67e74705SXin Li
47*67e74705SXin Li const MemRegion *LR = LV.getAsRegion();
48*67e74705SXin Li const MemRegion *RR = RV.getAsRegion();
49*67e74705SXin Li
50*67e74705SXin Li if (!(LR && RR))
51*67e74705SXin Li return;
52*67e74705SXin Li
53*67e74705SXin Li const MemRegion *BaseLR = LR->getBaseRegion();
54*67e74705SXin Li const MemRegion *BaseRR = RR->getBaseRegion();
55*67e74705SXin Li
56*67e74705SXin Li if (BaseLR == BaseRR)
57*67e74705SXin Li return;
58*67e74705SXin Li
59*67e74705SXin Li // Allow arithmetic on different symbolic regions.
60*67e74705SXin Li if (isa<SymbolicRegion>(BaseLR) || isa<SymbolicRegion>(BaseRR))
61*67e74705SXin Li return;
62*67e74705SXin Li
63*67e74705SXin Li if (ExplodedNode *N = C.generateNonFatalErrorNode()) {
64*67e74705SXin Li if (!BT)
65*67e74705SXin Li BT.reset(
66*67e74705SXin Li new BuiltinBug(this, "Pointer subtraction",
67*67e74705SXin Li "Subtraction of two pointers that do not point to "
68*67e74705SXin Li "the same memory chunk may cause incorrect result."));
69*67e74705SXin Li auto R = llvm::make_unique<BugReport>(*BT, BT->getDescription(), N);
70*67e74705SXin Li R->addRange(B->getSourceRange());
71*67e74705SXin Li C.emitReport(std::move(R));
72*67e74705SXin Li }
73*67e74705SXin Li }
74*67e74705SXin Li
registerPointerSubChecker(CheckerManager & mgr)75*67e74705SXin Li void ento::registerPointerSubChecker(CheckerManager &mgr) {
76*67e74705SXin Li mgr.registerChecker<PointerSubChecker>();
77*67e74705SXin Li }
78