1*67e74705SXin Li //=== StackAddrEscapeChecker.cpp ----------------------------------*- C++ -*--//
2*67e74705SXin Li //
3*67e74705SXin Li // The LLVM Compiler Infrastructure
4*67e74705SXin Li //
5*67e74705SXin Li // This file is distributed under the University of Illinois Open Source
6*67e74705SXin Li // License. See LICENSE.TXT for details.
7*67e74705SXin Li //
8*67e74705SXin Li //===----------------------------------------------------------------------===//
9*67e74705SXin Li //
10*67e74705SXin Li // This file defines stack address leak checker, which checks if an invalid
11*67e74705SXin Li // stack address is stored into a global or heap location. See CERT DCL30-C.
12*67e74705SXin Li //
13*67e74705SXin Li //===----------------------------------------------------------------------===//
14*67e74705SXin Li
15*67e74705SXin Li #include "ClangSACheckers.h"
16*67e74705SXin Li #include "clang/AST/ExprCXX.h"
17*67e74705SXin Li #include "clang/Basic/SourceManager.h"
18*67e74705SXin Li #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
19*67e74705SXin Li #include "clang/StaticAnalyzer/Core/Checker.h"
20*67e74705SXin Li #include "clang/StaticAnalyzer/Core/CheckerManager.h"
21*67e74705SXin Li #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
22*67e74705SXin Li #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23*67e74705SXin Li #include "llvm/ADT/SmallString.h"
24*67e74705SXin Li #include "llvm/Support/raw_ostream.h"
25*67e74705SXin Li using namespace clang;
26*67e74705SXin Li using namespace ento;
27*67e74705SXin Li
28*67e74705SXin Li namespace {
29*67e74705SXin Li class StackAddrEscapeChecker : public Checker< check::PreStmt<ReturnStmt>,
30*67e74705SXin Li check::EndFunction > {
31*67e74705SXin Li mutable std::unique_ptr<BuiltinBug> BT_stackleak;
32*67e74705SXin Li mutable std::unique_ptr<BuiltinBug> BT_returnstack;
33*67e74705SXin Li
34*67e74705SXin Li public:
35*67e74705SXin Li void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const;
36*67e74705SXin Li void checkEndFunction(CheckerContext &Ctx) const;
37*67e74705SXin Li private:
38*67e74705SXin Li void EmitStackError(CheckerContext &C, const MemRegion *R,
39*67e74705SXin Li const Expr *RetE) const;
40*67e74705SXin Li static SourceRange genName(raw_ostream &os, const MemRegion *R,
41*67e74705SXin Li ASTContext &Ctx);
42*67e74705SXin Li };
43*67e74705SXin Li }
44*67e74705SXin Li
genName(raw_ostream & os,const MemRegion * R,ASTContext & Ctx)45*67e74705SXin Li SourceRange StackAddrEscapeChecker::genName(raw_ostream &os, const MemRegion *R,
46*67e74705SXin Li ASTContext &Ctx) {
47*67e74705SXin Li // Get the base region, stripping away fields and elements.
48*67e74705SXin Li R = R->getBaseRegion();
49*67e74705SXin Li SourceManager &SM = Ctx.getSourceManager();
50*67e74705SXin Li SourceRange range;
51*67e74705SXin Li os << "Address of ";
52*67e74705SXin Li
53*67e74705SXin Li // Check if the region is a compound literal.
54*67e74705SXin Li if (const CompoundLiteralRegion* CR = dyn_cast<CompoundLiteralRegion>(R)) {
55*67e74705SXin Li const CompoundLiteralExpr *CL = CR->getLiteralExpr();
56*67e74705SXin Li os << "stack memory associated with a compound literal "
57*67e74705SXin Li "declared on line "
58*67e74705SXin Li << SM.getExpansionLineNumber(CL->getLocStart())
59*67e74705SXin Li << " returned to caller";
60*67e74705SXin Li range = CL->getSourceRange();
61*67e74705SXin Li }
62*67e74705SXin Li else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(R)) {
63*67e74705SXin Li const Expr *ARE = AR->getExpr();
64*67e74705SXin Li SourceLocation L = ARE->getLocStart();
65*67e74705SXin Li range = ARE->getSourceRange();
66*67e74705SXin Li os << "stack memory allocated by call to alloca() on line "
67*67e74705SXin Li << SM.getExpansionLineNumber(L);
68*67e74705SXin Li }
69*67e74705SXin Li else if (const BlockDataRegion *BR = dyn_cast<BlockDataRegion>(R)) {
70*67e74705SXin Li const BlockDecl *BD = BR->getCodeRegion()->getDecl();
71*67e74705SXin Li SourceLocation L = BD->getLocStart();
72*67e74705SXin Li range = BD->getSourceRange();
73*67e74705SXin Li os << "stack-allocated block declared on line "
74*67e74705SXin Li << SM.getExpansionLineNumber(L);
75*67e74705SXin Li }
76*67e74705SXin Li else if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
77*67e74705SXin Li os << "stack memory associated with local variable '"
78*67e74705SXin Li << VR->getString() << '\'';
79*67e74705SXin Li range = VR->getDecl()->getSourceRange();
80*67e74705SXin Li }
81*67e74705SXin Li else if (const CXXTempObjectRegion *TOR = dyn_cast<CXXTempObjectRegion>(R)) {
82*67e74705SXin Li QualType Ty = TOR->getValueType().getLocalUnqualifiedType();
83*67e74705SXin Li os << "stack memory associated with temporary object of type '";
84*67e74705SXin Li Ty.print(os, Ctx.getPrintingPolicy());
85*67e74705SXin Li os << "'";
86*67e74705SXin Li range = TOR->getExpr()->getSourceRange();
87*67e74705SXin Li }
88*67e74705SXin Li else {
89*67e74705SXin Li llvm_unreachable("Invalid region in ReturnStackAddressChecker.");
90*67e74705SXin Li }
91*67e74705SXin Li
92*67e74705SXin Li return range;
93*67e74705SXin Li }
94*67e74705SXin Li
EmitStackError(CheckerContext & C,const MemRegion * R,const Expr * RetE) const95*67e74705SXin Li void StackAddrEscapeChecker::EmitStackError(CheckerContext &C, const MemRegion *R,
96*67e74705SXin Li const Expr *RetE) const {
97*67e74705SXin Li ExplodedNode *N = C.generateErrorNode();
98*67e74705SXin Li
99*67e74705SXin Li if (!N)
100*67e74705SXin Li return;
101*67e74705SXin Li
102*67e74705SXin Li if (!BT_returnstack)
103*67e74705SXin Li BT_returnstack.reset(
104*67e74705SXin Li new BuiltinBug(this, "Return of address to stack-allocated memory"));
105*67e74705SXin Li
106*67e74705SXin Li // Generate a report for this bug.
107*67e74705SXin Li SmallString<512> buf;
108*67e74705SXin Li llvm::raw_svector_ostream os(buf);
109*67e74705SXin Li SourceRange range = genName(os, R, C.getASTContext());
110*67e74705SXin Li os << " returned to caller";
111*67e74705SXin Li auto report = llvm::make_unique<BugReport>(*BT_returnstack, os.str(), N);
112*67e74705SXin Li report->addRange(RetE->getSourceRange());
113*67e74705SXin Li if (range.isValid())
114*67e74705SXin Li report->addRange(range);
115*67e74705SXin Li
116*67e74705SXin Li C.emitReport(std::move(report));
117*67e74705SXin Li }
118*67e74705SXin Li
checkPreStmt(const ReturnStmt * RS,CheckerContext & C) const119*67e74705SXin Li void StackAddrEscapeChecker::checkPreStmt(const ReturnStmt *RS,
120*67e74705SXin Li CheckerContext &C) const {
121*67e74705SXin Li
122*67e74705SXin Li const Expr *RetE = RS->getRetValue();
123*67e74705SXin Li if (!RetE)
124*67e74705SXin Li return;
125*67e74705SXin Li RetE = RetE->IgnoreParens();
126*67e74705SXin Li
127*67e74705SXin Li const LocationContext *LCtx = C.getLocationContext();
128*67e74705SXin Li SVal V = C.getState()->getSVal(RetE, LCtx);
129*67e74705SXin Li const MemRegion *R = V.getAsRegion();
130*67e74705SXin Li
131*67e74705SXin Li if (!R)
132*67e74705SXin Li return;
133*67e74705SXin Li
134*67e74705SXin Li const StackSpaceRegion *SS =
135*67e74705SXin Li dyn_cast_or_null<StackSpaceRegion>(R->getMemorySpace());
136*67e74705SXin Li
137*67e74705SXin Li if (!SS)
138*67e74705SXin Li return;
139*67e74705SXin Li
140*67e74705SXin Li // Return stack memory in an ancestor stack frame is fine.
141*67e74705SXin Li const StackFrameContext *CurFrame = LCtx->getCurrentStackFrame();
142*67e74705SXin Li const StackFrameContext *MemFrame = SS->getStackFrame();
143*67e74705SXin Li if (MemFrame != CurFrame)
144*67e74705SXin Li return;
145*67e74705SXin Li
146*67e74705SXin Li // Automatic reference counting automatically copies blocks.
147*67e74705SXin Li if (C.getASTContext().getLangOpts().ObjCAutoRefCount &&
148*67e74705SXin Li isa<BlockDataRegion>(R))
149*67e74705SXin Li return;
150*67e74705SXin Li
151*67e74705SXin Li // Returning a record by value is fine. (In this case, the returned
152*67e74705SXin Li // expression will be a copy-constructor, possibly wrapped in an
153*67e74705SXin Li // ExprWithCleanups node.)
154*67e74705SXin Li if (const ExprWithCleanups *Cleanup = dyn_cast<ExprWithCleanups>(RetE))
155*67e74705SXin Li RetE = Cleanup->getSubExpr();
156*67e74705SXin Li if (isa<CXXConstructExpr>(RetE) && RetE->getType()->isRecordType())
157*67e74705SXin Li return;
158*67e74705SXin Li
159*67e74705SXin Li // The CK_CopyAndAutoreleaseBlockObject cast causes the block to be copied
160*67e74705SXin Li // so the stack address is not escaping here.
161*67e74705SXin Li if (auto *ICE = dyn_cast<ImplicitCastExpr>(RetE)) {
162*67e74705SXin Li if (isa<BlockDataRegion>(R) &&
163*67e74705SXin Li ICE->getCastKind() == CK_CopyAndAutoreleaseBlockObject) {
164*67e74705SXin Li return;
165*67e74705SXin Li }
166*67e74705SXin Li }
167*67e74705SXin Li
168*67e74705SXin Li EmitStackError(C, R, RetE);
169*67e74705SXin Li }
170*67e74705SXin Li
checkEndFunction(CheckerContext & Ctx) const171*67e74705SXin Li void StackAddrEscapeChecker::checkEndFunction(CheckerContext &Ctx) const {
172*67e74705SXin Li ProgramStateRef state = Ctx.getState();
173*67e74705SXin Li
174*67e74705SXin Li // Iterate over all bindings to global variables and see if it contains
175*67e74705SXin Li // a memory region in the stack space.
176*67e74705SXin Li class CallBack : public StoreManager::BindingsHandler {
177*67e74705SXin Li private:
178*67e74705SXin Li CheckerContext &Ctx;
179*67e74705SXin Li const StackFrameContext *CurSFC;
180*67e74705SXin Li public:
181*67e74705SXin Li SmallVector<std::pair<const MemRegion*, const MemRegion*>, 10> V;
182*67e74705SXin Li
183*67e74705SXin Li CallBack(CheckerContext &CC) :
184*67e74705SXin Li Ctx(CC),
185*67e74705SXin Li CurSFC(CC.getLocationContext()->getCurrentStackFrame())
186*67e74705SXin Li {}
187*67e74705SXin Li
188*67e74705SXin Li bool HandleBinding(StoreManager &SMgr, Store store,
189*67e74705SXin Li const MemRegion *region, SVal val) override {
190*67e74705SXin Li
191*67e74705SXin Li if (!isa<GlobalsSpaceRegion>(region->getMemorySpace()))
192*67e74705SXin Li return true;
193*67e74705SXin Li
194*67e74705SXin Li const MemRegion *vR = val.getAsRegion();
195*67e74705SXin Li if (!vR)
196*67e74705SXin Li return true;
197*67e74705SXin Li
198*67e74705SXin Li // Under automated retain release, it is okay to assign a block
199*67e74705SXin Li // directly to a global variable.
200*67e74705SXin Li if (Ctx.getASTContext().getLangOpts().ObjCAutoRefCount &&
201*67e74705SXin Li isa<BlockDataRegion>(vR))
202*67e74705SXin Li return true;
203*67e74705SXin Li
204*67e74705SXin Li if (const StackSpaceRegion *SSR =
205*67e74705SXin Li dyn_cast<StackSpaceRegion>(vR->getMemorySpace())) {
206*67e74705SXin Li // If the global variable holds a location in the current stack frame,
207*67e74705SXin Li // record the binding to emit a warning.
208*67e74705SXin Li if (SSR->getStackFrame() == CurSFC)
209*67e74705SXin Li V.push_back(std::make_pair(region, vR));
210*67e74705SXin Li }
211*67e74705SXin Li
212*67e74705SXin Li return true;
213*67e74705SXin Li }
214*67e74705SXin Li };
215*67e74705SXin Li
216*67e74705SXin Li CallBack cb(Ctx);
217*67e74705SXin Li state->getStateManager().getStoreManager().iterBindings(state->getStore(),cb);
218*67e74705SXin Li
219*67e74705SXin Li if (cb.V.empty())
220*67e74705SXin Li return;
221*67e74705SXin Li
222*67e74705SXin Li // Generate an error node.
223*67e74705SXin Li ExplodedNode *N = Ctx.generateNonFatalErrorNode(state);
224*67e74705SXin Li if (!N)
225*67e74705SXin Li return;
226*67e74705SXin Li
227*67e74705SXin Li if (!BT_stackleak)
228*67e74705SXin Li BT_stackleak.reset(
229*67e74705SXin Li new BuiltinBug(this, "Stack address stored into global variable",
230*67e74705SXin Li "Stack address was saved into a global variable. "
231*67e74705SXin Li "This is dangerous because the address will become "
232*67e74705SXin Li "invalid after returning from the function"));
233*67e74705SXin Li
234*67e74705SXin Li for (unsigned i = 0, e = cb.V.size(); i != e; ++i) {
235*67e74705SXin Li // Generate a report for this bug.
236*67e74705SXin Li SmallString<512> buf;
237*67e74705SXin Li llvm::raw_svector_ostream os(buf);
238*67e74705SXin Li SourceRange range = genName(os, cb.V[i].second, Ctx.getASTContext());
239*67e74705SXin Li os << " is still referred to by the ";
240*67e74705SXin Li if (isa<StaticGlobalSpaceRegion>(cb.V[i].first->getMemorySpace()))
241*67e74705SXin Li os << "static";
242*67e74705SXin Li else
243*67e74705SXin Li os << "global";
244*67e74705SXin Li os << " variable '";
245*67e74705SXin Li const VarRegion *VR = cast<VarRegion>(cb.V[i].first->getBaseRegion());
246*67e74705SXin Li os << *VR->getDecl()
247*67e74705SXin Li << "' upon returning to the caller. This will be a dangling reference";
248*67e74705SXin Li auto report = llvm::make_unique<BugReport>(*BT_stackleak, os.str(), N);
249*67e74705SXin Li if (range.isValid())
250*67e74705SXin Li report->addRange(range);
251*67e74705SXin Li
252*67e74705SXin Li Ctx.emitReport(std::move(report));
253*67e74705SXin Li }
254*67e74705SXin Li }
255*67e74705SXin Li
registerStackAddrEscapeChecker(CheckerManager & mgr)256*67e74705SXin Li void ento::registerStackAddrEscapeChecker(CheckerManager &mgr) {
257*67e74705SXin Li mgr.registerChecker<StackAddrEscapeChecker>();
258*67e74705SXin Li }
259