1*67e74705SXin Li //===--- UndefinedAssignmentChecker.h ---------------------------*- C++ -*--==//
2*67e74705SXin Li //
3*67e74705SXin Li // The LLVM Compiler Infrastructure
4*67e74705SXin Li //
5*67e74705SXin Li // This file is distributed under the University of Illinois Open Source
6*67e74705SXin Li // License. See LICENSE.TXT for details.
7*67e74705SXin Li //
8*67e74705SXin Li //===----------------------------------------------------------------------===//
9*67e74705SXin Li //
10*67e74705SXin Li // This defines UndefinedAssignmentChecker, a builtin check in ExprEngine that
11*67e74705SXin Li // checks for assigning undefined values.
12*67e74705SXin Li //
13*67e74705SXin Li //===----------------------------------------------------------------------===//
14*67e74705SXin Li
15*67e74705SXin Li #include "ClangSACheckers.h"
16*67e74705SXin Li #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
17*67e74705SXin Li #include "clang/StaticAnalyzer/Core/Checker.h"
18*67e74705SXin Li #include "clang/StaticAnalyzer/Core/CheckerManager.h"
19*67e74705SXin Li #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
20*67e74705SXin Li
21*67e74705SXin Li using namespace clang;
22*67e74705SXin Li using namespace ento;
23*67e74705SXin Li
24*67e74705SXin Li namespace {
25*67e74705SXin Li class UndefinedAssignmentChecker
26*67e74705SXin Li : public Checker<check::Bind> {
27*67e74705SXin Li mutable std::unique_ptr<BugType> BT;
28*67e74705SXin Li
29*67e74705SXin Li public:
30*67e74705SXin Li void checkBind(SVal location, SVal val, const Stmt *S,
31*67e74705SXin Li CheckerContext &C) const;
32*67e74705SXin Li };
33*67e74705SXin Li }
34*67e74705SXin Li
checkBind(SVal location,SVal val,const Stmt * StoreE,CheckerContext & C) const35*67e74705SXin Li void UndefinedAssignmentChecker::checkBind(SVal location, SVal val,
36*67e74705SXin Li const Stmt *StoreE,
37*67e74705SXin Li CheckerContext &C) const {
38*67e74705SXin Li if (!val.isUndef())
39*67e74705SXin Li return;
40*67e74705SXin Li
41*67e74705SXin Li // Do not report assignments of uninitialized values inside swap functions.
42*67e74705SXin Li // This should allow to swap partially uninitialized structs
43*67e74705SXin Li // (radar://14129997)
44*67e74705SXin Li if (const FunctionDecl *EnclosingFunctionDecl =
45*67e74705SXin Li dyn_cast<FunctionDecl>(C.getStackFrame()->getDecl()))
46*67e74705SXin Li if (C.getCalleeName(EnclosingFunctionDecl) == "swap")
47*67e74705SXin Li return;
48*67e74705SXin Li
49*67e74705SXin Li ExplodedNode *N = C.generateErrorNode();
50*67e74705SXin Li
51*67e74705SXin Li if (!N)
52*67e74705SXin Li return;
53*67e74705SXin Li
54*67e74705SXin Li const char *str = "Assigned value is garbage or undefined";
55*67e74705SXin Li
56*67e74705SXin Li if (!BT)
57*67e74705SXin Li BT.reset(new BuiltinBug(this, str));
58*67e74705SXin Li
59*67e74705SXin Li // Generate a report for this bug.
60*67e74705SXin Li const Expr *ex = nullptr;
61*67e74705SXin Li
62*67e74705SXin Li while (StoreE) {
63*67e74705SXin Li if (const BinaryOperator *B = dyn_cast<BinaryOperator>(StoreE)) {
64*67e74705SXin Li if (B->isCompoundAssignmentOp()) {
65*67e74705SXin Li ProgramStateRef state = C.getState();
66*67e74705SXin Li if (state->getSVal(B->getLHS(), C.getLocationContext()).isUndef()) {
67*67e74705SXin Li str = "The left expression of the compound assignment is an "
68*67e74705SXin Li "uninitialized value. The computed value will also be garbage";
69*67e74705SXin Li ex = B->getLHS();
70*67e74705SXin Li break;
71*67e74705SXin Li }
72*67e74705SXin Li }
73*67e74705SXin Li
74*67e74705SXin Li ex = B->getRHS();
75*67e74705SXin Li break;
76*67e74705SXin Li }
77*67e74705SXin Li
78*67e74705SXin Li if (const DeclStmt *DS = dyn_cast<DeclStmt>(StoreE)) {
79*67e74705SXin Li const VarDecl *VD = dyn_cast<VarDecl>(DS->getSingleDecl());
80*67e74705SXin Li ex = VD->getInit();
81*67e74705SXin Li }
82*67e74705SXin Li
83*67e74705SXin Li break;
84*67e74705SXin Li }
85*67e74705SXin Li
86*67e74705SXin Li auto R = llvm::make_unique<BugReport>(*BT, str, N);
87*67e74705SXin Li if (ex) {
88*67e74705SXin Li R->addRange(ex->getSourceRange());
89*67e74705SXin Li bugreporter::trackNullOrUndefValue(N, ex, *R);
90*67e74705SXin Li }
91*67e74705SXin Li C.emitReport(std::move(R));
92*67e74705SXin Li }
93*67e74705SXin Li
registerUndefinedAssignmentChecker(CheckerManager & mgr)94*67e74705SXin Li void ento::registerUndefinedAssignmentChecker(CheckerManager &mgr) {
95*67e74705SXin Li mgr.registerChecker<UndefinedAssignmentChecker>();
96*67e74705SXin Li }
97