1*cc02d7e2SAndroid Build Coastguard Worker#!/usr/bin/env python3 2*cc02d7e2SAndroid Build Coastguard Worker 3*cc02d7e2SAndroid Build Coastguard Worker# Copyright 2022 gRPC authors. 4*cc02d7e2SAndroid Build Coastguard Worker# 5*cc02d7e2SAndroid Build Coastguard Worker# Licensed under the Apache License, Version 2.0 (the "License"); 6*cc02d7e2SAndroid Build Coastguard Worker# you may not use this file except in compliance with the License. 7*cc02d7e2SAndroid Build Coastguard Worker# You may obtain a copy of the License at 8*cc02d7e2SAndroid Build Coastguard Worker# 9*cc02d7e2SAndroid Build Coastguard Worker# http://www.apache.org/licenses/LICENSE-2.0 10*cc02d7e2SAndroid Build Coastguard Worker# 11*cc02d7e2SAndroid Build Coastguard Worker# Unless required by applicable law or agreed to in writing, software 12*cc02d7e2SAndroid Build Coastguard Worker# distributed under the License is distributed on an "AS IS" BASIS, 13*cc02d7e2SAndroid Build Coastguard Worker# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 14*cc02d7e2SAndroid Build Coastguard Worker# See the License for the specific language governing permissions and 15*cc02d7e2SAndroid Build Coastguard Worker# limitations under the License. 16*cc02d7e2SAndroid Build Coastguard Worker 17*cc02d7e2SAndroid Build Coastguard Workerimport argparse 18*cc02d7e2SAndroid Build Coastguard Workerimport os 19*cc02d7e2SAndroid Build Coastguard Workerimport os.path 20*cc02d7e2SAndroid Build Coastguard Workerimport re 21*cc02d7e2SAndroid Build Coastguard Workerimport subprocess 22*cc02d7e2SAndroid Build Coastguard Workerimport sys 23*cc02d7e2SAndroid Build Coastguard Worker 24*cc02d7e2SAndroid Build Coastguard Worker# TODO(hork): dedupe args/load/validate/save code with other check scripts. 25*cc02d7e2SAndroid Build Coastguard Worker 26*cc02d7e2SAndroid Build Coastguard Worker 27*cc02d7e2SAndroid Build Coastguard Workerdef load(fpath): 28*cc02d7e2SAndroid Build Coastguard Worker with open(fpath, "r") as f: 29*cc02d7e2SAndroid Build Coastguard Worker return f.readlines() 30*cc02d7e2SAndroid Build Coastguard Worker 31*cc02d7e2SAndroid Build Coastguard Worker 32*cc02d7e2SAndroid Build Coastguard Workerdef save(fpath, contents): 33*cc02d7e2SAndroid Build Coastguard Worker with open(fpath, "w") as f: 34*cc02d7e2SAndroid Build Coastguard Worker f.write(contents) 35*cc02d7e2SAndroid Build Coastguard Worker 36*cc02d7e2SAndroid Build Coastguard Worker 37*cc02d7e2SAndroid Build Coastguard Workerclass QualificationValidator(object): 38*cc02d7e2SAndroid Build Coastguard Worker def __init__(self): 39*cc02d7e2SAndroid Build Coastguard Worker self.fully_qualified_re = re.compile(r"([ (<])::(grpc[A-Za-z_:])") 40*cc02d7e2SAndroid Build Coastguard Worker self.using_re = re.compile( 41*cc02d7e2SAndroid Build Coastguard Worker r"(using +|using +[A-Za-z_]+ *= *|namespace [A-Za-z_]+ *= *)::" 42*cc02d7e2SAndroid Build Coastguard Worker ) 43*cc02d7e2SAndroid Build Coastguard Worker self.define_re = re.compile(r"^#define") 44*cc02d7e2SAndroid Build Coastguard Worker 45*cc02d7e2SAndroid Build Coastguard Worker def check(self, fpath, fix): 46*cc02d7e2SAndroid Build Coastguard Worker fcontents = load(fpath) 47*cc02d7e2SAndroid Build Coastguard Worker failed = False 48*cc02d7e2SAndroid Build Coastguard Worker for i, line in enumerate(fcontents): 49*cc02d7e2SAndroid Build Coastguard Worker if not self.fully_qualified_re.search(line): 50*cc02d7e2SAndroid Build Coastguard Worker continue 51*cc02d7e2SAndroid Build Coastguard Worker # skip `using` statements 52*cc02d7e2SAndroid Build Coastguard Worker if self.using_re.search(line): 53*cc02d7e2SAndroid Build Coastguard Worker continue 54*cc02d7e2SAndroid Build Coastguard Worker # skip `#define` statements 55*cc02d7e2SAndroid Build Coastguard Worker if self.define_re.search(line): 56*cc02d7e2SAndroid Build Coastguard Worker continue 57*cc02d7e2SAndroid Build Coastguard Worker # fully-qualified namespace found, which may be unnecessary 58*cc02d7e2SAndroid Build Coastguard Worker if fix: 59*cc02d7e2SAndroid Build Coastguard Worker fcontents[i] = self.fully_qualified_re.sub(r"\1\2", line) 60*cc02d7e2SAndroid Build Coastguard Worker else: 61*cc02d7e2SAndroid Build Coastguard Worker print("Found in %s:%d - %s" % (fpath, i, line.strip())) 62*cc02d7e2SAndroid Build Coastguard Worker failed = True 63*cc02d7e2SAndroid Build Coastguard Worker if fix: 64*cc02d7e2SAndroid Build Coastguard Worker save(fpath, "".join(fcontents)) 65*cc02d7e2SAndroid Build Coastguard Worker return not failed 66*cc02d7e2SAndroid Build Coastguard Worker 67*cc02d7e2SAndroid Build Coastguard Worker 68*cc02d7e2SAndroid Build Coastguard WorkerIGNORED_FILES = [ 69*cc02d7e2SAndroid Build Coastguard Worker # TODO(hork): rename symbols to avoid the need for fully-qualified names 70*cc02d7e2SAndroid Build Coastguard Worker "src/cpp/common/core_codegen.cc", 71*cc02d7e2SAndroid Build Coastguard Worker # TODO(hork): This could be a breaking change for users that define their 72*cc02d7e2SAndroid Build Coastguard Worker # own (possibly nested) `grpc.*` namespaces that contain conflicting 73*cc02d7e2SAndroid Build Coastguard Worker # symbols. It may be worth trying to land this change at some point, as 74*cc02d7e2SAndroid Build Coastguard Worker # users would be better off using unique namespaces. 75*cc02d7e2SAndroid Build Coastguard Worker "src/compiler/cpp_generator.cc", 76*cc02d7e2SAndroid Build Coastguard Worker # multi-line #define statements are not handled 77*cc02d7e2SAndroid Build Coastguard Worker "src/core/lib/gprpp/global_config_env.h", 78*cc02d7e2SAndroid Build Coastguard Worker "src/core/lib/profiling/timers.h", 79*cc02d7e2SAndroid Build Coastguard Worker "src/core/lib/gprpp/crash.h", 80*cc02d7e2SAndroid Build Coastguard Worker] 81*cc02d7e2SAndroid Build Coastguard Worker 82*cc02d7e2SAndroid Build Coastguard Worker# find our home 83*cc02d7e2SAndroid Build Coastguard WorkerROOT = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]), "../..")) 84*cc02d7e2SAndroid Build Coastguard Workeros.chdir(ROOT) 85*cc02d7e2SAndroid Build Coastguard Worker 86*cc02d7e2SAndroid Build Coastguard Worker# parse command line 87*cc02d7e2SAndroid Build Coastguard Workerargp = argparse.ArgumentParser( 88*cc02d7e2SAndroid Build Coastguard Worker description="c++ namespace full qualification checker" 89*cc02d7e2SAndroid Build Coastguard Worker) 90*cc02d7e2SAndroid Build Coastguard Workerargp.add_argument("-f", "--fix", default=False, action="store_true") 91*cc02d7e2SAndroid Build Coastguard Workerargp.add_argument("--precommit", default=False, action="store_true") 92*cc02d7e2SAndroid Build Coastguard Workerargs = argp.parse_args() 93*cc02d7e2SAndroid Build Coastguard Worker 94*cc02d7e2SAndroid Build Coastguard Workergrep_filter = r"grep -E '^(include|src|test).*\.(h|cc)$'" 95*cc02d7e2SAndroid Build Coastguard Workerif args.precommit: 96*cc02d7e2SAndroid Build Coastguard Worker git_command = "git diff --name-only HEAD" 97*cc02d7e2SAndroid Build Coastguard Workerelse: 98*cc02d7e2SAndroid Build Coastguard Worker git_command = "git ls-tree -r --name-only -r HEAD" 99*cc02d7e2SAndroid Build Coastguard Worker 100*cc02d7e2SAndroid Build Coastguard WorkerFILE_LIST_COMMAND = " | ".join((git_command, grep_filter)) 101*cc02d7e2SAndroid Build Coastguard Worker 102*cc02d7e2SAndroid Build Coastguard Worker# scan files 103*cc02d7e2SAndroid Build Coastguard Workerok = True 104*cc02d7e2SAndroid Build Coastguard Workerfilename_list = [] 105*cc02d7e2SAndroid Build Coastguard Workertry: 106*cc02d7e2SAndroid Build Coastguard Worker filename_list = ( 107*cc02d7e2SAndroid Build Coastguard Worker subprocess.check_output(FILE_LIST_COMMAND, shell=True) 108*cc02d7e2SAndroid Build Coastguard Worker .decode() 109*cc02d7e2SAndroid Build Coastguard Worker .splitlines() 110*cc02d7e2SAndroid Build Coastguard Worker ) 111*cc02d7e2SAndroid Build Coastguard Worker # Filter out non-existent files (ie, file removed or renamed) 112*cc02d7e2SAndroid Build Coastguard Worker filename_list = (f for f in filename_list if os.path.isfile(f)) 113*cc02d7e2SAndroid Build Coastguard Workerexcept subprocess.CalledProcessError: 114*cc02d7e2SAndroid Build Coastguard Worker sys.exit(0) 115*cc02d7e2SAndroid Build Coastguard Worker 116*cc02d7e2SAndroid Build Coastguard Workervalidator = QualificationValidator() 117*cc02d7e2SAndroid Build Coastguard Worker 118*cc02d7e2SAndroid Build Coastguard Workerfor filename in filename_list: 119*cc02d7e2SAndroid Build Coastguard Worker # Skip check for upb generated code and ignored files. 120*cc02d7e2SAndroid Build Coastguard Worker if ( 121*cc02d7e2SAndroid Build Coastguard Worker filename.endswith(".upb.h") 122*cc02d7e2SAndroid Build Coastguard Worker or filename.endswith(".upbdefs.h") 123*cc02d7e2SAndroid Build Coastguard Worker or filename.endswith(".upbdefs.c") 124*cc02d7e2SAndroid Build Coastguard Worker or filename in IGNORED_FILES 125*cc02d7e2SAndroid Build Coastguard Worker ): 126*cc02d7e2SAndroid Build Coastguard Worker continue 127*cc02d7e2SAndroid Build Coastguard Worker ok = validator.check(filename, args.fix) and ok 128*cc02d7e2SAndroid Build Coastguard Worker 129*cc02d7e2SAndroid Build Coastguard Workersys.exit(0 if ok else 1) 130