1*053f45beSAndroid Build Coastguard WorkerFrom e75167b426e722ebd11623ae50891d321d245b59 Mon Sep 17 00:00:00 2001 2*053f45beSAndroid Build Coastguard WorkerFrom: George Burgess IV <[email protected]> 3*053f45beSAndroid Build Coastguard WorkerDate: Mon, 31 Jul 2017 13:55:52 -0700 4*053f45beSAndroid Build Coastguard WorkerSubject: [PATCH 03/20] kcmp_test: Remove useless open mode 5*053f45beSAndroid Build Coastguard Worker 6*053f45beSAndroid Build Coastguard WorkerOpen modes are ignored if the user doesn't want the file to be created: 7*053f45beSAndroid Build Coastguard Workerhttp://man7.org/linux/man-pages/man2/open.2.html 8*053f45beSAndroid Build Coastguard Worker 9*053f45beSAndroid Build Coastguard WorkerSince it's somewhat misleading/potentially indicative of a missing 10*053f45beSAndroid Build Coastguard WorkerO_CREAT/O_TMPFILE, we plan to issue a warning on open calls with useless 11*053f45beSAndroid Build Coastguard Workermode bits in the near future. Because -Werror is used in this project 12*053f45beSAndroid Build Coastguard Worker(thank you!), we need to either make the mode useful, or remove it. 13*053f45beSAndroid Build Coastguard Worker 14*053f45beSAndroid Build Coastguard Worker(cherry picked from commit 0bba2e896d09c7ef7b49a409ba5cd869531befa9) 15*053f45beSAndroid Build Coastguard WorkerBug: 64132680 16*053f45beSAndroid Build Coastguard WorkerTest: mma. New warning no longer appears. 17*053f45beSAndroid Build Coastguard Worker--- 18*053f45beSAndroid Build Coastguard Worker tools/testing/selftests/kcmp/kcmp_test.c | 2 +- 19*053f45beSAndroid Build Coastguard Worker 1 file changed, 1 insertion(+), 1 deletion(-) 20*053f45beSAndroid Build Coastguard Worker 21*053f45beSAndroid Build Coastguard Workerdiff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c 22*053f45beSAndroid Build Coastguard Workerindex 25110c7c0b3e..d7a8e321bb16 100644 23*053f45beSAndroid Build Coastguard Worker--- a/tools/testing/selftests/kcmp/kcmp_test.c 24*053f45beSAndroid Build Coastguard Worker+++ b/tools/testing/selftests/kcmp/kcmp_test.c 25*053f45beSAndroid Build Coastguard Worker@@ -91,7 +91,7 @@ int main(int argc, char **argv) 26*053f45beSAndroid Build Coastguard Worker ksft_print_header(); 27*053f45beSAndroid Build Coastguard Worker ksft_set_plan(3); 28*053f45beSAndroid Build Coastguard Worker 29*053f45beSAndroid Build Coastguard Worker- fd2 = open(kpath, O_RDWR, 0644); 30*053f45beSAndroid Build Coastguard Worker+ fd2 = open(kpath, O_RDWR); 31*053f45beSAndroid Build Coastguard Worker if (fd2 < 0) { 32*053f45beSAndroid Build Coastguard Worker perror("Can't open file"); 33*053f45beSAndroid Build Coastguard Worker ksft_exit_fail(); 34*053f45beSAndroid Build Coastguard Worker-- 35*053f45beSAndroid Build Coastguard Worker2.42.0.609.gbb76f46606-goog 36*053f45beSAndroid Build Coastguard Worker 37