1*49cdfc7eSAndroid Build Coastguard Worker // SPDX-License-Identifier: GPL-2.0-or-later
2*49cdfc7eSAndroid Build Coastguard Worker /*
3*49cdfc7eSAndroid Build Coastguard Worker * Copyright (c) 2020 SUSE LLC <[email protected]>
4*49cdfc7eSAndroid Build Coastguard Worker */
5*49cdfc7eSAndroid Build Coastguard Worker
6*49cdfc7eSAndroid Build Coastguard Worker /*
7*49cdfc7eSAndroid Build Coastguard Worker * CVE-2019-8912
8*49cdfc7eSAndroid Build Coastguard Worker *
9*49cdfc7eSAndroid Build Coastguard Worker * Check for possible use-after-free in sockfs_setattr() on AF_ALG socket
10*49cdfc7eSAndroid Build Coastguard Worker * closed by dup2() or dup3(). Unlike regular close(), dup*() syscalls don't
11*49cdfc7eSAndroid Build Coastguard Worker * set sock->sk = NULL after closing the socket. Racing fchownat() against
12*49cdfc7eSAndroid Build Coastguard Worker * dup2() may then result in sockfs_setattr() using the stale pointer and
13*49cdfc7eSAndroid Build Coastguard Worker * writing into a block of released memory that may have been reused in the
14*49cdfc7eSAndroid Build Coastguard Worker * mean time.
15*49cdfc7eSAndroid Build Coastguard Worker *
16*49cdfc7eSAndroid Build Coastguard Worker * The race window is small and it's hard to trigger a kernel crash but
17*49cdfc7eSAndroid Build Coastguard Worker * fchownat() will return ENOENT as it should only when the bug is not
18*49cdfc7eSAndroid Build Coastguard Worker * present. Race fixed specifically for af_alg in:
19*49cdfc7eSAndroid Build Coastguard Worker *
20*49cdfc7eSAndroid Build Coastguard Worker * commit 9060cb719e61b685ec0102574e10337fa5f445ea
21*49cdfc7eSAndroid Build Coastguard Worker * Author: Mao Wenan <[email protected]>
22*49cdfc7eSAndroid Build Coastguard Worker * Date: Mon Feb 18 10:44:44 2019 +0800
23*49cdfc7eSAndroid Build Coastguard Worker *
24*49cdfc7eSAndroid Build Coastguard Worker * net: crypto set sk to NULL when af_alg_release.
25*49cdfc7eSAndroid Build Coastguard Worker *
26*49cdfc7eSAndroid Build Coastguard Worker * It was observed that the same bug is present on many other
27*49cdfc7eSAndroid Build Coastguard Worker * protocols. A more general fix is in:
28*49cdfc7eSAndroid Build Coastguard Worker *
29*49cdfc7eSAndroid Build Coastguard Worker * commit ff7b11aa481f682e0e9711abfeb7d03f5cd612bf
30*49cdfc7eSAndroid Build Coastguard Worker * Author: Eric Biggers <[email protected]>
31*49cdfc7eSAndroid Build Coastguard Worker * Date: Thu Feb 21 14:13:56 2019 -0800
32*49cdfc7eSAndroid Build Coastguard Worker *
33*49cdfc7eSAndroid Build Coastguard Worker * net: socket: set sock->sk to NULL after calling proto_ops::release()
34*49cdfc7eSAndroid Build Coastguard Worker */
35*49cdfc7eSAndroid Build Coastguard Worker
36*49cdfc7eSAndroid Build Coastguard Worker #include <sys/types.h>
37*49cdfc7eSAndroid Build Coastguard Worker #include <sys/stat.h>
38*49cdfc7eSAndroid Build Coastguard Worker #include <unistd.h>
39*49cdfc7eSAndroid Build Coastguard Worker #include <pwd.h>
40*49cdfc7eSAndroid Build Coastguard Worker #include "lapi/fcntl.h"
41*49cdfc7eSAndroid Build Coastguard Worker
42*49cdfc7eSAndroid Build Coastguard Worker #include "tst_test.h"
43*49cdfc7eSAndroid Build Coastguard Worker #include "tst_af_alg.h"
44*49cdfc7eSAndroid Build Coastguard Worker #include "tst_fuzzy_sync.h"
45*49cdfc7eSAndroid Build Coastguard Worker #include "tst_taint.h"
46*49cdfc7eSAndroid Build Coastguard Worker
47*49cdfc7eSAndroid Build Coastguard Worker static int fd = -1, sock = -1;
48*49cdfc7eSAndroid Build Coastguard Worker static int uid, gid;
49*49cdfc7eSAndroid Build Coastguard Worker static struct tst_fzsync_pair fzsync_pair;
50*49cdfc7eSAndroid Build Coastguard Worker
setup(void)51*49cdfc7eSAndroid Build Coastguard Worker static void setup(void)
52*49cdfc7eSAndroid Build Coastguard Worker {
53*49cdfc7eSAndroid Build Coastguard Worker uid = getuid();
54*49cdfc7eSAndroid Build Coastguard Worker gid = getgid();
55*49cdfc7eSAndroid Build Coastguard Worker
56*49cdfc7eSAndroid Build Coastguard Worker fd = SAFE_OPEN("tmpfile", O_RDWR | O_CREAT, 0644);
57*49cdfc7eSAndroid Build Coastguard Worker
58*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_pair_init(&fzsync_pair);
59*49cdfc7eSAndroid Build Coastguard Worker }
60*49cdfc7eSAndroid Build Coastguard Worker
thread_run(void * arg)61*49cdfc7eSAndroid Build Coastguard Worker static void *thread_run(void *arg)
62*49cdfc7eSAndroid Build Coastguard Worker {
63*49cdfc7eSAndroid Build Coastguard Worker while (tst_fzsync_run_b(&fzsync_pair)) {
64*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_start_race_b(&fzsync_pair);
65*49cdfc7eSAndroid Build Coastguard Worker dup2(fd, sock);
66*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_end_race_b(&fzsync_pair);
67*49cdfc7eSAndroid Build Coastguard Worker }
68*49cdfc7eSAndroid Build Coastguard Worker
69*49cdfc7eSAndroid Build Coastguard Worker return arg;
70*49cdfc7eSAndroid Build Coastguard Worker }
71*49cdfc7eSAndroid Build Coastguard Worker
run(void)72*49cdfc7eSAndroid Build Coastguard Worker static void run(void)
73*49cdfc7eSAndroid Build Coastguard Worker {
74*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_pair_reset(&fzsync_pair, thread_run);
75*49cdfc7eSAndroid Build Coastguard Worker
76*49cdfc7eSAndroid Build Coastguard Worker while (tst_fzsync_run_a(&fzsync_pair)) {
77*49cdfc7eSAndroid Build Coastguard Worker sock = tst_alg_setup_reqfd("hash", "sha1", NULL, 0);
78*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_start_race_a(&fzsync_pair);
79*49cdfc7eSAndroid Build Coastguard Worker TEST(fchownat(sock, "", uid, gid, AT_EMPTY_PATH));
80*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_end_race_a(&fzsync_pair);
81*49cdfc7eSAndroid Build Coastguard Worker SAFE_CLOSE(sock);
82*49cdfc7eSAndroid Build Coastguard Worker
83*49cdfc7eSAndroid Build Coastguard Worker if (tst_taint_check()) {
84*49cdfc7eSAndroid Build Coastguard Worker tst_res(TFAIL, "Kernel is vulnerable");
85*49cdfc7eSAndroid Build Coastguard Worker return;
86*49cdfc7eSAndroid Build Coastguard Worker }
87*49cdfc7eSAndroid Build Coastguard Worker
88*49cdfc7eSAndroid Build Coastguard Worker if (TST_RET == -1 && TST_ERR == EBADF) {
89*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_pair_add_bias(&fzsync_pair, 1);
90*49cdfc7eSAndroid Build Coastguard Worker continue;
91*49cdfc7eSAndroid Build Coastguard Worker }
92*49cdfc7eSAndroid Build Coastguard Worker
93*49cdfc7eSAndroid Build Coastguard Worker if (TST_RET == -1 && TST_ERR == ENOENT) {
94*49cdfc7eSAndroid Build Coastguard Worker tst_res(TPASS | TTERRNO,
95*49cdfc7eSAndroid Build Coastguard Worker "fchownat() failed successfully");
96*49cdfc7eSAndroid Build Coastguard Worker return;
97*49cdfc7eSAndroid Build Coastguard Worker }
98*49cdfc7eSAndroid Build Coastguard Worker
99*49cdfc7eSAndroid Build Coastguard Worker if (TST_RET == -1) {
100*49cdfc7eSAndroid Build Coastguard Worker tst_brk(TBROK | TTERRNO,
101*49cdfc7eSAndroid Build Coastguard Worker "fchownat() failed unexpectedly");
102*49cdfc7eSAndroid Build Coastguard Worker }
103*49cdfc7eSAndroid Build Coastguard Worker
104*49cdfc7eSAndroid Build Coastguard Worker if (TST_RET) {
105*49cdfc7eSAndroid Build Coastguard Worker tst_brk(TBROK | TTERRNO,
106*49cdfc7eSAndroid Build Coastguard Worker "Invalid fchownat() return value");
107*49cdfc7eSAndroid Build Coastguard Worker }
108*49cdfc7eSAndroid Build Coastguard Worker }
109*49cdfc7eSAndroid Build Coastguard Worker
110*49cdfc7eSAndroid Build Coastguard Worker tst_res(TFAIL, "fchownat() failed to fail, kernel may be vulnerable");
111*49cdfc7eSAndroid Build Coastguard Worker }
112*49cdfc7eSAndroid Build Coastguard Worker
cleanup(void)113*49cdfc7eSAndroid Build Coastguard Worker static void cleanup(void)
114*49cdfc7eSAndroid Build Coastguard Worker {
115*49cdfc7eSAndroid Build Coastguard Worker tst_fzsync_pair_cleanup(&fzsync_pair);
116*49cdfc7eSAndroid Build Coastguard Worker
117*49cdfc7eSAndroid Build Coastguard Worker if (fd >= 0)
118*49cdfc7eSAndroid Build Coastguard Worker SAFE_CLOSE(fd);
119*49cdfc7eSAndroid Build Coastguard Worker }
120*49cdfc7eSAndroid Build Coastguard Worker
121*49cdfc7eSAndroid Build Coastguard Worker static struct tst_test test = {
122*49cdfc7eSAndroid Build Coastguard Worker .needs_tmpdir = 1,
123*49cdfc7eSAndroid Build Coastguard Worker .test_all = run,
124*49cdfc7eSAndroid Build Coastguard Worker .setup = setup,
125*49cdfc7eSAndroid Build Coastguard Worker .cleanup = cleanup,
126*49cdfc7eSAndroid Build Coastguard Worker .min_kver = "4.10.0",
127*49cdfc7eSAndroid Build Coastguard Worker .min_cpus = 2,
128*49cdfc7eSAndroid Build Coastguard Worker .max_runtime = 150,
129*49cdfc7eSAndroid Build Coastguard Worker .taint_check = TST_TAINT_W | TST_TAINT_D,
130*49cdfc7eSAndroid Build Coastguard Worker .tags = (const struct tst_tag[]) {
131*49cdfc7eSAndroid Build Coastguard Worker {"linux-git", "ff7b11aa481f"},
132*49cdfc7eSAndroid Build Coastguard Worker {"linux-git", "9060cb719e61"},
133*49cdfc7eSAndroid Build Coastguard Worker {"CVE", "2019-8912"},
134*49cdfc7eSAndroid Build Coastguard Worker {}
135*49cdfc7eSAndroid Build Coastguard Worker }
136*49cdfc7eSAndroid Build Coastguard Worker };
137