xref: /aosp_15_r20/external/perfetto/python/tools/presubmit_utils.py (revision 6dbdd20afdafa5e3ca9b8809fa73465d530080dc)
1*6dbdd20aSAndroid Build Coastguard Worker#!/usr/bin/env python3
2*6dbdd20aSAndroid Build Coastguard Worker# Copyright (C) 2023 The Android Open Source Project
3*6dbdd20aSAndroid Build Coastguard Worker#
4*6dbdd20aSAndroid Build Coastguard Worker# Licensed under the Apache License, Version 2.0 (the "License");
5*6dbdd20aSAndroid Build Coastguard Worker# you may not use this file except in compliance with the License.
6*6dbdd20aSAndroid Build Coastguard Worker# You may obtain a copy of the License at
7*6dbdd20aSAndroid Build Coastguard Worker#
8*6dbdd20aSAndroid Build Coastguard Worker#      http://www.apache.org/licenses/LICENSE-2.0
9*6dbdd20aSAndroid Build Coastguard Worker#
10*6dbdd20aSAndroid Build Coastguard Worker# Unless required by applicable law or agreed to in writing, software
11*6dbdd20aSAndroid Build Coastguard Worker# distributed under the License is distributed on an "AS IS" BASIS,
12*6dbdd20aSAndroid Build Coastguard Worker# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13*6dbdd20aSAndroid Build Coastguard Worker# See the License for the specific language governing permissions and
14*6dbdd20aSAndroid Build Coastguard Worker# limitations under the License.
15*6dbdd20aSAndroid Build Coastguard Worker"""
16*6dbdd20aSAndroid Build Coastguard WorkerEnforce import rules for https://ui.perfetto.dev.
17*6dbdd20aSAndroid Build Coastguard WorkerDirectory structure encodes ideas about the expected dependency graph
18*6dbdd20aSAndroid Build Coastguard Workerof the code in those directories. Both in a fuzzy sense: we expect code
19*6dbdd20aSAndroid Build Coastguard Workerwithing a directory to have high cohesion within the directory and low
20*6dbdd20aSAndroid Build Coastguard Workercoupling (aka fewer imports) outside of the directory - but also
21*6dbdd20aSAndroid Build Coastguard Workerconcrete rules:
22*6dbdd20aSAndroid Build Coastguard Worker- "base should not depend on the fronted"
23*6dbdd20aSAndroid Build Coastguard Worker- "plugins should only directly depend on the public API"
24*6dbdd20aSAndroid Build Coastguard Worker- "we should not have circular dependencies"
25*6dbdd20aSAndroid Build Coastguard Worker
26*6dbdd20aSAndroid Build Coastguard WorkerWithout enforcement exceptions to this rule quickly slip in. This
27*6dbdd20aSAndroid Build Coastguard Workerscript allows such rules to be enforced at presubmit time.
28*6dbdd20aSAndroid Build Coastguard Worker"""
29