1*ec63e07aSXin Li // Copyright 2019 Google LLC
2*ec63e07aSXin Li //
3*ec63e07aSXin Li // Licensed under the Apache License, Version 2.0 (the "License");
4*ec63e07aSXin Li // you may not use this file except in compliance with the License.
5*ec63e07aSXin Li // You may obtain a copy of the License at
6*ec63e07aSXin Li //
7*ec63e07aSXin Li // https://www.apache.org/licenses/LICENSE-2.0
8*ec63e07aSXin Li //
9*ec63e07aSXin Li // Unless required by applicable law or agreed to in writing, software
10*ec63e07aSXin Li // distributed under the License is distributed on an "AS IS" BASIS,
11*ec63e07aSXin Li // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12*ec63e07aSXin Li // See the License for the specific language governing permissions and
13*ec63e07aSXin Li // limitations under the License.
14*ec63e07aSXin Li
15*ec63e07aSXin Li #include "sandboxed_api/sandbox2/policybuilder.h"
16*ec63e07aSXin Li
17*ec63e07aSXin Li #include <syscall.h>
18*ec63e07aSXin Li #include <unistd.h>
19*ec63e07aSXin Li
20*ec63e07aSXin Li #include <cerrno>
21*ec63e07aSXin Li #include <memory>
22*ec63e07aSXin Li #include <string>
23*ec63e07aSXin Li #include <vector>
24*ec63e07aSXin Li
25*ec63e07aSXin Li #include "gmock/gmock.h"
26*ec63e07aSXin Li #include "gtest/gtest.h"
27*ec63e07aSXin Li #include "absl/status/status.h"
28*ec63e07aSXin Li #include "absl/status/statusor.h"
29*ec63e07aSXin Li #include "absl/strings/string_view.h"
30*ec63e07aSXin Li #include "sandboxed_api/sandbox2/policy.h"
31*ec63e07aSXin Li #include "sandboxed_api/sandbox2/util/bpf_helper.h"
32*ec63e07aSXin Li #include "sandboxed_api/sandbox2/violation.pb.h"
33*ec63e07aSXin Li #include "sandboxed_api/util/status_matchers.h"
34*ec63e07aSXin Li
35*ec63e07aSXin Li namespace sandbox2 {
36*ec63e07aSXin Li
37*ec63e07aSXin Li class PolicyBuilderPeer {
38*ec63e07aSXin Li public:
PolicyBuilderPeer(PolicyBuilder * builder)39*ec63e07aSXin Li explicit PolicyBuilderPeer(PolicyBuilder* builder) : builder_{builder} {}
40*ec63e07aSXin Li
policy_size() const41*ec63e07aSXin Li int policy_size() const { return builder_->user_policy_.size(); }
42*ec63e07aSXin Li
ValidateAbsolutePath(absl::string_view path)43*ec63e07aSXin Li static absl::StatusOr<std::string> ValidateAbsolutePath(
44*ec63e07aSXin Li absl::string_view path) {
45*ec63e07aSXin Li return PolicyBuilder::ValidateAbsolutePath(path);
46*ec63e07aSXin Li }
47*ec63e07aSXin Li
48*ec63e07aSXin Li private:
49*ec63e07aSXin Li PolicyBuilder* builder_;
50*ec63e07aSXin Li };
51*ec63e07aSXin Li
52*ec63e07aSXin Li namespace {
53*ec63e07aSXin Li
54*ec63e07aSXin Li using ::sapi::IsOk;
55*ec63e07aSXin Li using ::sapi::StatusIs;
56*ec63e07aSXin Li using ::testing::Eq;
57*ec63e07aSXin Li using ::testing::Lt;
58*ec63e07aSXin Li using ::testing::StartsWith;
59*ec63e07aSXin Li using ::testing::StrEq;
60*ec63e07aSXin Li
TEST(PolicyBuilderTest,Testpolicy_size)61*ec63e07aSXin Li TEST(PolicyBuilderTest, Testpolicy_size) {
62*ec63e07aSXin Li ssize_t last_size = 0;
63*ec63e07aSXin Li PolicyBuilder builder;
64*ec63e07aSXin Li PolicyBuilderPeer builder_peer{&builder};
65*ec63e07aSXin Li
66*ec63e07aSXin Li auto assert_increased = [&last_size, &builder_peer]() {
67*ec63e07aSXin Li ASSERT_THAT(last_size, Lt(builder_peer.policy_size()));
68*ec63e07aSXin Li last_size = builder_peer.policy_size();
69*ec63e07aSXin Li };
70*ec63e07aSXin Li
71*ec63e07aSXin Li auto assert_same = [&last_size, &builder_peer]() {
72*ec63e07aSXin Li ASSERT_THAT(last_size, Eq(builder_peer.policy_size()));
73*ec63e07aSXin Li };
74*ec63e07aSXin Li
75*ec63e07aSXin Li // clang-format off
76*ec63e07aSXin Li assert_same();
77*ec63e07aSXin Li
78*ec63e07aSXin Li builder.AllowSyscall(__NR_chroot); assert_increased();
79*ec63e07aSXin Li builder.AllowSyscall(__NR_chroot); assert_same();
80*ec63e07aSXin Li builder.AllowSyscall(__NR_umask); assert_increased();
81*ec63e07aSXin Li builder.AllowSyscall(__NR_umask); assert_same();
82*ec63e07aSXin Li builder.AllowSyscall(__NR_chroot); assert_same();
83*ec63e07aSXin Li builder.AllowSyscall(__NR_chroot); assert_same();
84*ec63e07aSXin Li
85*ec63e07aSXin Li builder.AllowSystemMalloc(); assert_increased();
86*ec63e07aSXin Li builder.AllowSyscall(__NR_munmap); assert_same();
87*ec63e07aSXin Li builder.BlockSyscallWithErrno(__NR_munmap, 1); assert_same();
88*ec63e07aSXin Li builder.BlockSyscallWithErrno(__NR_openat, 1);
89*ec63e07aSXin Li assert_increased();
90*ec63e07aSXin Li
91*ec63e07aSXin Li builder.AllowTCGETS(); assert_increased();
92*ec63e07aSXin Li builder.AllowTCGETS(); assert_increased();
93*ec63e07aSXin Li builder.AllowTCGETS(); assert_increased();
94*ec63e07aSXin Li
95*ec63e07aSXin Li builder.AddPolicyOnSyscall(__NR_fchmod, { ALLOW }); assert_increased();
96*ec63e07aSXin Li builder.AddPolicyOnSyscall(__NR_fchmod, { ALLOW }); assert_increased();
97*ec63e07aSXin Li
98*ec63e07aSXin Li builder.AddPolicyOnSyscalls({ __NR_fchmod, __NR_chdir }, { ALLOW });
99*ec63e07aSXin Li assert_increased();
100*ec63e07aSXin Li builder.AddPolicyOnSyscalls({ __NR_fchmod, __NR_chdir }, { ALLOW });
101*ec63e07aSXin Li assert_increased();
102*ec63e07aSXin Li
103*ec63e07aSXin Li // This might change in the future if we implement an optimization.
104*ec63e07aSXin Li builder.AddPolicyOnSyscall(__NR_umask, { ALLOW }); assert_increased();
105*ec63e07aSXin Li builder.AddPolicyOnSyscall(__NR_umask, { ALLOW }); assert_increased();
106*ec63e07aSXin Li
107*ec63e07aSXin Li // None of the namespace functions should alter the seccomp policy.
108*ec63e07aSXin Li builder.AddFile("/usr/bin/find"); assert_same();
109*ec63e07aSXin Li builder.AddDirectory("/bin"); assert_same();
110*ec63e07aSXin Li builder.AddTmpfs("/tmp", /*size=*/4ULL << 20 /* 4 MiB */); assert_same();
111*ec63e07aSXin Li builder.AllowUnrestrictedNetworking(); assert_same();
112*ec63e07aSXin Li // clang-format on
113*ec63e07aSXin Li }
114*ec63e07aSXin Li
TEST(PolicyBuilderTest,TestValidateAbsolutePath)115*ec63e07aSXin Li TEST(PolicyBuilderTest, TestValidateAbsolutePath) {
116*ec63e07aSXin Li for (auto const& bad_path : {
117*ec63e07aSXin Li "..",
118*ec63e07aSXin Li "a",
119*ec63e07aSXin Li "a/b",
120*ec63e07aSXin Li "a/b/c",
121*ec63e07aSXin Li "/a/b/c/../d",
122*ec63e07aSXin Li "/a/b/c/./d",
123*ec63e07aSXin Li "/a/b/c//d",
124*ec63e07aSXin Li "/a/b/c/d/",
125*ec63e07aSXin Li "/a/bAAAAAAAAAAAAAAAAAAAAAA/c/d/",
126*ec63e07aSXin Li }) {
127*ec63e07aSXin Li EXPECT_THAT(PolicyBuilderPeer::ValidateAbsolutePath(bad_path),
128*ec63e07aSXin Li StatusIs(absl::StatusCode::kInvalidArgument));
129*ec63e07aSXin Li }
130*ec63e07aSXin Li
131*ec63e07aSXin Li for (auto const& good_path :
132*ec63e07aSXin Li {"/", "/a/b/c/d", "/a/b/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"}) {
133*ec63e07aSXin Li SAPI_ASSERT_OK_AND_ASSIGN(
134*ec63e07aSXin Li std::string path, PolicyBuilderPeer::ValidateAbsolutePath(good_path));
135*ec63e07aSXin Li EXPECT_THAT(path, StrEq(good_path));
136*ec63e07aSXin Li }
137*ec63e07aSXin Li }
138*ec63e07aSXin Li
TEST(PolicyBuilderTest,TestCanOnlyBuildOnce)139*ec63e07aSXin Li TEST(PolicyBuilderTest, TestCanOnlyBuildOnce) {
140*ec63e07aSXin Li PolicyBuilder b;
141*ec63e07aSXin Li ASSERT_THAT(b.TryBuild(), IsOk());
142*ec63e07aSXin Li EXPECT_THAT(b.TryBuild(), StatusIs(absl::StatusCode::kFailedPrecondition,
143*ec63e07aSXin Li "Can only build policy once."));
144*ec63e07aSXin Li }
145*ec63e07aSXin Li
TEST(PolicyBuilderTest,TestIsCopyable)146*ec63e07aSXin Li TEST(PolicyBuilderTest, TestIsCopyable) {
147*ec63e07aSXin Li PolicyBuilder builder;
148*ec63e07aSXin Li builder.AllowSyscall(__NR_getpid);
149*ec63e07aSXin Li
150*ec63e07aSXin Li PolicyBuilder copy = builder;
151*ec63e07aSXin Li ASSERT_EQ(PolicyBuilderPeer(©).policy_size(),
152*ec63e07aSXin Li PolicyBuilderPeer(&builder).policy_size());
153*ec63e07aSXin Li
154*ec63e07aSXin Li // Both can be built.
155*ec63e07aSXin Li EXPECT_THAT(builder.TryBuild(), IsOk());
156*ec63e07aSXin Li EXPECT_THAT(copy.TryBuild(), IsOk());
157*ec63e07aSXin Li }
158*ec63e07aSXin Li
TEST(PolicyBuilderTest,CanBypassPtrace)159*ec63e07aSXin Li TEST(PolicyBuilderTest, CanBypassPtrace) {
160*ec63e07aSXin Li PolicyBuilder builder;
161*ec63e07aSXin Li builder.AddPolicyOnSyscall(__NR_ptrace, {ALLOW})
162*ec63e07aSXin Li .BlockSyscallWithErrno(__NR_ptrace, ENOENT);
163*ec63e07aSXin Li EXPECT_THAT(builder.TryBuild(), Not(IsOk()));
164*ec63e07aSXin Li }
165*ec63e07aSXin Li
TEST(PolicyBuilderTest,AddPolicyOnSyscallsNoEmptyList)166*ec63e07aSXin Li TEST(PolicyBuilderTest, AddPolicyOnSyscallsNoEmptyList) {
167*ec63e07aSXin Li PolicyBuilder builder;
168*ec63e07aSXin Li builder.AddPolicyOnSyscalls({}, {ALLOW});
169*ec63e07aSXin Li EXPECT_THAT(builder.TryBuild(), StatusIs(absl::StatusCode::kInvalidArgument));
170*ec63e07aSXin Li }
171*ec63e07aSXin Li
TEST(PolicyBuilderTest,AddPolicyOnSyscallJumpOutOfBounds)172*ec63e07aSXin Li TEST(PolicyBuilderTest, AddPolicyOnSyscallJumpOutOfBounds) {
173*ec63e07aSXin Li PolicyBuilder builder;
174*ec63e07aSXin Li builder.AddPolicyOnSyscall(__NR_write,
175*ec63e07aSXin Li {BPF_JUMP(BPF_JMP | BPF_JEQ | BPF_K, 1, 2, 0)});
176*ec63e07aSXin Li EXPECT_THAT(builder.TryBuild(), StatusIs(absl::StatusCode::kInvalidArgument));
177*ec63e07aSXin Li }
178*ec63e07aSXin Li } // namespace
179*ec63e07aSXin Li } // namespace sandbox2
180