1 /*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17 #include <errno.h>
18 #include <stdlib.h>
19 #include <string.h>
20 #include <unistd.h>
21
22 #include <android-base/logging.h>
23 #include <android-base/scopeguard.h>
24 #include <gmock/gmock.h>
25 #include <gtest/gtest.h>
26
27 #include "InstalldNativeService.h"
28 #include "MatchExtensionGen.h"
29 #include "globals.h"
30 #include "utils.h"
31
32 #undef LOG_TAG
33 #define LOG_TAG "utils_test"
34
35 #define TEST_DATA_DIR "/data/"
36 #define TEST_ROOT_DIR "/system/"
37 #define TEST_APP_DIR "/data/app/"
38 #define TEST_APP_PRIVATE_DIR "/data/app-private/"
39 #define TEST_APP_EPHEMERAL_DIR "/data/app-ephemeral/"
40 #define TEST_ASEC_DIR "/mnt/asec/"
41 #define TEST_EXPAND_DIR "/mnt/expand/00000000-0000-0000-0000-000000000000/"
42
43 #define TEST_SYSTEM_DIR1 "/system/app/"
44 #define TEST_SYSTEM_DIR2 "/vendor/app/"
45
46 #define TEST_PROFILE_DIR "/data/misc/profiles"
47
48 namespace android {
49 namespace installd {
50
51 using ::testing::UnorderedElementsAre;
52
53 class UtilsTest : public testing::Test {
54 protected:
SetUp()55 virtual void SetUp() {
56 setenv("ANDROID_LOG_TAGS", "*:v", 1);
57 android::base::InitLogging(nullptr);
58
59 init_globals_from_data_and_root(TEST_DATA_DIR, TEST_ROOT_DIR);
60 }
61
TearDown()62 virtual void TearDown() {
63 }
64
create_too_long_path(const std::string & seed)65 std::string create_too_long_path(const std::string& seed) {
66 std::string result = seed;
67 for (size_t i = seed.size(); i < PKG_PATH_MAX; i++) {
68 result += "a";
69 }
70 return result;
71 }
72 };
73
TEST_F(UtilsTest,IsValidApkPath_BadPrefix)74 TEST_F(UtilsTest, IsValidApkPath_BadPrefix) {
75 // Bad prefixes directories
76 const char *badprefix1 = "/etc/passwd";
77 EXPECT_EQ(-1, validate_apk_path(badprefix1))
78 << badprefix1 << " should not be allowed as a valid path";
79
80 const char *badprefix2 = "../.." TEST_APP_DIR "../../../blah";
81 EXPECT_EQ(-1, validate_apk_path(badprefix2))
82 << badprefix2 << " should not be allowed as a valid path";
83
84 const char *badprefix3 = "init.rc";
85 EXPECT_EQ(-1, validate_apk_path(badprefix3))
86 << badprefix3 << " should not be allowed as a valid path";
87
88 const char *badprefix4 = "/init.rc";
89 EXPECT_EQ(-1, validate_apk_path(badprefix4))
90 << badprefix4 << " should not be allowed as a valid path";
91 }
92
TEST_F(UtilsTest,IsValidApkPath_Internal)93 TEST_F(UtilsTest, IsValidApkPath_Internal) {
94 // Internal directories
95 const char *internal1 = TEST_APP_DIR "example.apk";
96 EXPECT_EQ(0, validate_apk_path(internal1))
97 << internal1 << " should be allowed as a valid path";
98
99 // b/16888084
100 const char *path2 = TEST_APP_DIR "example.com/example.apk";
101 EXPECT_EQ(0, validate_apk_path(path2))
102 << path2 << " should be allowed as a valid path";
103
104 const char* path3 = TEST_APP_DIR "..example..com../example.apk";
105 EXPECT_EQ(0, validate_apk_path(path3)) << path3 << " should be allowed as a valid path";
106
107 const char *badint1 = TEST_APP_DIR "../example.apk";
108 EXPECT_EQ(-1, validate_apk_path(badint1))
109 << badint1 << " should be rejected as a invalid path";
110
111 const char *badint2 = TEST_APP_DIR "/../example.apk";
112 EXPECT_EQ(-1, validate_apk_path(badint2))
113 << badint2 << " should be rejected as a invalid path";
114
115 // Should not have more than two sub directories
116 const char *bad_path3 = TEST_APP_DIR "random/example.com/subdir/pkg.apk";
117 EXPECT_EQ(-1, validate_apk_path(bad_path3))
118 << bad_path3 << " should be rejected as a invalid path";
119
120 const char *bad_path4 = TEST_APP_DIR "random/example.com/subdir/pkg.apk";
121 EXPECT_EQ(-1, validate_apk_path(bad_path4))
122 << bad_path4 << " should be rejected as a invalid path";
123
124 const char *bad_path5 = TEST_APP_DIR "example.com1/../example.com2/pkg.apk";
125 EXPECT_EQ(-1, validate_apk_path(bad_path5))
126 << bad_path5 << " should be rejected as a invalid path";
127 }
128
TEST_F(UtilsTest,IsValidApkPath_TopDir)129 TEST_F(UtilsTest, IsValidApkPath_TopDir) {
130 EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/com.example"));
131 EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/random/com.example"));
132 EXPECT_EQ(0, validate_apk_path(TEST_EXPAND_DIR "app/com.example"));
133 EXPECT_EQ(-1, validate_apk_path(TEST_DATA_DIR "data/com.example"));
134 EXPECT_EQ(-1, validate_apk_path(TEST_EXPAND_DIR "data/com.example"));
135 }
136
TEST_F(UtilsTest,IsValidApkPath_TopFile)137 TEST_F(UtilsTest, IsValidApkPath_TopFile) {
138 EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/com.example/base.apk"));
139 EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/random/com.example/base.apk"));
140 EXPECT_EQ(0, validate_apk_path(TEST_EXPAND_DIR "app/com.example/base.apk"));
141 EXPECT_EQ(-1, validate_apk_path(TEST_DATA_DIR "data/com.example/base.apk"));
142 EXPECT_EQ(-1, validate_apk_path(TEST_EXPAND_DIR "data/com.example/base.apk"));
143 }
144
TEST_F(UtilsTest,IsValidApkPath_OatDir)145 TEST_F(UtilsTest, IsValidApkPath_OatDir) {
146 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/com.example/oat"));
147 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/random/com.example/oat"));
148 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_EXPAND_DIR "app/com.example/oat"));
149 EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_DATA_DIR "data/com.example/oat"));
150 EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_EXPAND_DIR "data/com.example/oat"));
151 }
152
TEST_F(UtilsTest,IsValidApkPath_OatDirDir)153 TEST_F(UtilsTest, IsValidApkPath_OatDirDir) {
154 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/com.example/oat/arm64"));
155 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/random/com.example/oat/arm64"));
156 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_EXPAND_DIR "app/com.example/oat/arm64"));
157 EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_DATA_DIR "data/com.example/oat/arm64"));
158 EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_EXPAND_DIR "data/com.example/oat/arm64"));
159 }
160
TEST_F(UtilsTest,IsValidApkPath_OatDirDirFile)161 TEST_F(UtilsTest, IsValidApkPath_OatDirDirFile) {
162 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/com.example/oat/arm64/base.odex"));
163 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/random/com.example/oat/arm64/base.odex"));
164 EXPECT_EQ(0, validate_apk_path_subdirs(TEST_EXPAND_DIR "app/com.example/oat/arm64/base.odex"));
165 EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_DATA_DIR "data/com.example/oat/arm64/base.odex"));
166 EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_EXPAND_DIR "data/com.example/oat/arm64/base.odex"));
167 }
168
TEST_F(UtilsTest,IsValidApkPath_Private)169 TEST_F(UtilsTest, IsValidApkPath_Private) {
170 // Internal directories
171 const char *private1 = TEST_APP_PRIVATE_DIR "example.apk";
172 EXPECT_EQ(0, validate_apk_path(private1))
173 << private1 << " should be allowed as a valid path";
174
175 // b/16888084
176 const char *path2 = TEST_APP_DIR "example.com/example.apk";
177 EXPECT_EQ(0, validate_apk_path(path2))
178 << path2 << " should be allowed as a valid path";
179
180 const char *path3 = TEST_APP_DIR "random/example.com/example.apk";
181 EXPECT_EQ(0, validate_apk_path(path3))
182 << path3 << " should be allowed as a valid path";
183
184 const char *badpriv1 = TEST_APP_PRIVATE_DIR "../example.apk";
185 EXPECT_EQ(-1, validate_apk_path(badpriv1))
186 << badpriv1 << " should be rejected as a invalid path";
187
188 const char *badpriv2 = TEST_APP_PRIVATE_DIR "/../example.apk";
189 EXPECT_EQ(-1, validate_apk_path(badpriv2))
190 << badpriv2 << " should be rejected as a invalid path";
191
192 // Only one or two subdir should be allowed.
193 const char *bad_path3 = TEST_APP_PRIVATE_DIR "random/example.com/subdir/pkg.apk";
194 EXPECT_EQ(-1, validate_apk_path(bad_path3))
195 << bad_path3 << " should be rejected as a invalid path";
196
197 const char *bad_path4 = TEST_APP_PRIVATE_DIR "random/example.com/subdir/../pkg.apk";
198 EXPECT_EQ(-1, validate_apk_path(bad_path4))
199 << bad_path4 << " should be rejected as a invalid path";
200
201 const char *bad_path5 = TEST_APP_PRIVATE_DIR "random/example.com1/../example.com2/pkg.apk";
202 EXPECT_EQ(-1, validate_apk_path(bad_path5))
203 << bad_path5 << " should be rejected as a invalid path";
204 }
205
206
TEST_F(UtilsTest,IsValidApkPath_AsecGood1)207 TEST_F(UtilsTest, IsValidApkPath_AsecGood1) {
208 const char *asec1 = TEST_ASEC_DIR "example.apk";
209 EXPECT_EQ(0, validate_apk_path(asec1))
210 << asec1 << " should be allowed as a valid path";
211 }
212
TEST_F(UtilsTest,IsValidApkPath_AsecGood2)213 TEST_F(UtilsTest, IsValidApkPath_AsecGood2) {
214 const char *asec2 = TEST_ASEC_DIR "com.example.asec/pkg.apk";
215 EXPECT_EQ(0, validate_apk_path(asec2))
216 << asec2 << " should be allowed as a valid path";
217 }
218
TEST_F(UtilsTest,IsValidApkPath_EscapeFail)219 TEST_F(UtilsTest, IsValidApkPath_EscapeFail) {
220 const char *badasec1 = TEST_ASEC_DIR "../example.apk";
221 EXPECT_EQ(-1, validate_apk_path(badasec1))
222 << badasec1 << " should be rejected as a invalid path";
223 }
224
TEST_F(UtilsTest,IsValidApkPath_SubdirEscapeFail)225 TEST_F(UtilsTest, IsValidApkPath_SubdirEscapeFail) {
226 const char *badasec3 = TEST_ASEC_DIR "com.example.asec/../../../pkg.apk";
227 EXPECT_EQ(-1, validate_apk_path(badasec3))
228 << badasec3 << " should be rejected as a invalid path";
229 }
230
TEST_F(UtilsTest,IsValidApkPath_SlashEscapeFail)231 TEST_F(UtilsTest, IsValidApkPath_SlashEscapeFail) {
232 const char *badasec4 = TEST_ASEC_DIR "/../example.apk";
233 EXPECT_EQ(-1, validate_apk_path(badasec4))
234 << badasec4 << " should be rejected as a invalid path";
235 }
236
TEST_F(UtilsTest,IsValidApkPath_CrazyDirFail)237 TEST_F(UtilsTest, IsValidApkPath_CrazyDirFail) {
238 const char *badasec5 = TEST_ASEC_DIR ".//../..";
239 EXPECT_EQ(-1, validate_apk_path(badasec5))
240 << badasec5 << " should be rejected as a invalid path";
241 }
242
TEST_F(UtilsTest,IsValidApkPath_SubdirEscapeSingleFail)243 TEST_F(UtilsTest, IsValidApkPath_SubdirEscapeSingleFail) {
244 const char *badasec6 = TEST_ASEC_DIR "com.example.asec/../pkg.apk";
245 EXPECT_EQ(-1, validate_apk_path(badasec6))
246 << badasec6 << " should be rejected as a invalid path";
247 }
248
TEST_F(UtilsTest,IsValidApkPath_TwoSubdir)249 TEST_F(UtilsTest, IsValidApkPath_TwoSubdir) {
250 const char *badasec7 = TEST_ASEC_DIR "random/com.example.asec/pkg.apk";
251 EXPECT_EQ(0, validate_apk_path(badasec7))
252 << badasec7 << " should be allowed as a valid path";
253 }
254
TEST_F(UtilsTest,IsValidApkPath_ThreeSubdirFail)255 TEST_F(UtilsTest, IsValidApkPath_ThreeSubdirFail) {
256 const char *badasec8 = TEST_ASEC_DIR "random/com.example.asec/subdir/pkg.apk";
257 EXPECT_EQ(-1, validate_apk_path(badasec8))
258 << badasec8 << " should be rejcted as an invalid path";
259 }
260
TEST_F(UtilsTest,CheckSystemApp_Dir1)261 TEST_F(UtilsTest, CheckSystemApp_Dir1) {
262 const char *sysapp1 = TEST_SYSTEM_DIR1 "Voice.apk";
263 EXPECT_EQ(0, validate_system_app_path(sysapp1))
264 << sysapp1 << " should be allowed as a system path";
265 }
266
TEST_F(UtilsTest,CheckSystemApp_Dir2)267 TEST_F(UtilsTest, CheckSystemApp_Dir2) {
268 const char *sysapp2 = TEST_SYSTEM_DIR2 "com.example.myapp.apk";
269 EXPECT_EQ(0, validate_system_app_path(sysapp2))
270 << sysapp2 << " should be allowed as a system path";
271 }
272
TEST_F(UtilsTest,CheckSystemApp_EscapeFail)273 TEST_F(UtilsTest, CheckSystemApp_EscapeFail) {
274 const char *badapp1 = TEST_SYSTEM_DIR1 "../com.example.apk";
275 EXPECT_EQ(-1, validate_system_app_path(badapp1))
276 << badapp1 << " should be rejected not a system path";
277 }
278
TEST_F(UtilsTest,CheckSystemApp_DoubleEscapeFail)279 TEST_F(UtilsTest, CheckSystemApp_DoubleEscapeFail) {
280 const char *badapp2 = TEST_SYSTEM_DIR2 "/../../com.example.apk";
281 EXPECT_EQ(-1, validate_system_app_path(badapp2))
282 << badapp2 << " should be rejected not a system path";
283 }
284
TEST_F(UtilsTest,CheckSystemApp_BadPathEscapeFail)285 TEST_F(UtilsTest, CheckSystemApp_BadPathEscapeFail) {
286 const char *badapp3 = TEST_APP_DIR "/../../com.example.apk";
287 EXPECT_EQ(-1, validate_system_app_path(badapp3))
288 << badapp3 << " should be rejected not a system path";
289 }
290
TEST_F(UtilsTest,CheckSystemApp_Subdir)291 TEST_F(UtilsTest, CheckSystemApp_Subdir) {
292 const char *sysapp = TEST_SYSTEM_DIR1 "com.example/com.example.apk";
293 EXPECT_EQ(0, validate_system_app_path(sysapp))
294 << sysapp << " should be allowed as a system path";
295
296 const char *badapp = TEST_SYSTEM_DIR1 "com.example/subdir/com.example.apk";
297 EXPECT_EQ(-1, validate_system_app_path(badapp))
298 << badapp << " should be rejected not a system path";
299
300 const char *badapp1 = TEST_SYSTEM_DIR1 "com.example/subdir/../com.example.apk";
301 EXPECT_EQ(-1, validate_system_app_path(badapp1))
302 << badapp1 << " should be rejected not a system path";
303
304 const char *badapp2 = TEST_SYSTEM_DIR1 "com.example1/../com.example2/com.example.apk";
305 EXPECT_EQ(-1, validate_system_app_path(badapp2))
306 << badapp2 << " should be rejected not a system path";
307 }
308
TEST_F(UtilsTest,CreateDataPath)309 TEST_F(UtilsTest, CreateDataPath) {
310 EXPECT_EQ("/data", create_data_path(nullptr));
311 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b",
312 create_data_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b"));
313 }
314
TEST_F(UtilsTest,CreateDataAppPath)315 TEST_F(UtilsTest, CreateDataAppPath) {
316 EXPECT_EQ("/data/app", create_data_app_path(nullptr));
317
318 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/app",
319 create_data_app_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b"));
320 }
321
TEST_F(UtilsTest,CreateDataUserPath)322 TEST_F(UtilsTest, CreateDataUserPath) {
323 EXPECT_EQ("/data/data", create_data_user_ce_path(nullptr, 0));
324 EXPECT_EQ("/data/user/10", create_data_user_ce_path(nullptr, 10));
325
326 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/0",
327 create_data_user_ce_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0));
328 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/10",
329 create_data_user_ce_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10));
330 }
331
TEST_F(UtilsTest,CreateDataMediaPath)332 TEST_F(UtilsTest, CreateDataMediaPath) {
333 EXPECT_EQ("/data/media/0", create_data_media_path(nullptr, 0));
334 EXPECT_EQ("/data/media/10", create_data_media_path(nullptr, 10));
335
336 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/media/0",
337 create_data_media_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0));
338 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/media/10",
339 create_data_media_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10));
340 }
341
TEST_F(UtilsTest,CreateDataUserPackagePath)342 TEST_F(UtilsTest, CreateDataUserPackagePath) {
343 EXPECT_EQ("/data/data/com.example", create_data_user_ce_package_path(nullptr, 0, "com.example"));
344 EXPECT_EQ("/data/user/10/com.example", create_data_user_ce_package_path(nullptr, 10, "com.example"));
345
346 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/0/com.example",
347 create_data_user_ce_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0, "com.example"));
348 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/10/com.example",
349 create_data_user_ce_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10, "com.example"));
350 }
351
TEST_F(UtilsTest,IsValidPackageName)352 TEST_F(UtilsTest, IsValidPackageName) {
353 EXPECT_EQ(true, is_valid_package_name("android"));
354 EXPECT_EQ(true, is_valid_package_name("com.example"));
355 EXPECT_EQ(true, is_valid_package_name("com.example-1"));
356 EXPECT_EQ(true, is_valid_package_name("com.example-1024"));
357 EXPECT_EQ(true, is_valid_package_name("com.example.foo---KiJFj4a_tePVw95pSrjg=="));
358 EXPECT_EQ(true, is_valid_package_name("really_LONG.a1234.package_name"));
359
360 EXPECT_EQ(false, is_valid_package_name("1234.package"));
361 EXPECT_EQ(false, is_valid_package_name("com.1234.package"));
362 EXPECT_EQ(false, is_valid_package_name(""));
363 EXPECT_EQ(false, is_valid_package_name("."));
364 EXPECT_EQ(false, is_valid_package_name(".."));
365 EXPECT_EQ(false, is_valid_package_name("../"));
366 EXPECT_EQ(false, is_valid_package_name("com.example/../com.evil/"));
367 EXPECT_EQ(false, is_valid_package_name("com.example-1/../com.evil/"));
368 EXPECT_EQ(false, is_valid_package_name("/com.evil"));
369 }
370
TEST_F(UtilsTest,CreateDataUserProfilePath)371 TEST_F(UtilsTest, CreateDataUserProfilePath) {
372 EXPECT_EQ("/data/misc/profiles/cur/0", create_primary_cur_profile_dir_path(0));
373 EXPECT_EQ("/data/misc/profiles/cur/1", create_primary_cur_profile_dir_path(1));
374 }
375
TEST_F(UtilsTest,CreateDataUserProfilePackagePath)376 TEST_F(UtilsTest, CreateDataUserProfilePackagePath) {
377 EXPECT_EQ("/data/misc/profiles/cur/0/com.example",
378 create_primary_current_profile_package_dir_path(0, "com.example"));
379 EXPECT_EQ("/data/misc/profiles/cur/1/com.example",
380 create_primary_current_profile_package_dir_path(1, "com.example"));
381 }
382
TEST_F(UtilsTest,CreateDataRefProfilePath)383 TEST_F(UtilsTest, CreateDataRefProfilePath) {
384 EXPECT_EQ("/data/misc/profiles/ref", create_primary_ref_profile_dir_path());
385 }
386
TEST_F(UtilsTest,CreateDataRefProfilePackagePath)387 TEST_F(UtilsTest, CreateDataRefProfilePackagePath) {
388 EXPECT_EQ("/data/misc/profiles/ref/com.example",
389 create_primary_reference_profile_package_dir_path("com.example"));
390 }
391
TEST_F(UtilsTest,CreatePrimaryCurrentProfile)392 TEST_F(UtilsTest, CreatePrimaryCurrentProfile) {
393 std::string expected_base =
394 create_primary_current_profile_package_dir_path(0, "com.example") + "/primary.prof";
395 EXPECT_EQ(expected_base,
396 create_current_profile_path(/*user*/0, "com.example", "primary.prof",
397 /*is_secondary*/false));
398
399 std::string expected_split =
400 create_primary_current_profile_package_dir_path(0, "com.example") + "/split.prof";
401 EXPECT_EQ(expected_split,
402 create_current_profile_path(/*user*/0, "com.example", "split.prof",
403 /*is_secondary*/false));
404 }
405
TEST_F(UtilsTest,CreatePrimaryReferenceProfile)406 TEST_F(UtilsTest, CreatePrimaryReferenceProfile) {
407 std::string expected_base =
408 create_primary_reference_profile_package_dir_path("com.example") + "/primary.prof";
409 EXPECT_EQ(expected_base,
410 create_reference_profile_path("com.example", "primary.prof", /*is_secondary*/false));
411
412 std::string expected_split =
413 create_primary_reference_profile_package_dir_path("com.example") + "/split.prof";
414 EXPECT_EQ(expected_split,
415 create_reference_profile_path("com.example", "split.prof", /*is_secondary*/false));
416 }
417
TEST_F(UtilsTest,CreateProfileSnapshot)418 TEST_F(UtilsTest, CreateProfileSnapshot) {
419 std::string expected_base =
420 create_primary_reference_profile_package_dir_path("com.example") + "/primary.prof.snapshot";
421 EXPECT_EQ(expected_base, create_snapshot_profile_path("com.example", "primary.prof"));
422
423 std::string expected_split =
424 create_primary_reference_profile_package_dir_path("com.example") + "/split.prof.snapshot";
425 EXPECT_EQ(expected_split, create_snapshot_profile_path("com.example", "split.prof"));
426 }
427
TEST_F(UtilsTest,CreateSecondaryCurrentProfile)428 TEST_F(UtilsTest, CreateSecondaryCurrentProfile) {
429 EXPECT_EQ("/data/user/0/com.example/oat/secondary.dex.cur.prof",
430 create_current_profile_path(/*user*/0, "com.example",
431 "/data/user/0/com.example/secondary.dex", /*is_secondary*/true));
432 }
433
TEST_F(UtilsTest,CreateSecondaryReferenceProfile)434 TEST_F(UtilsTest, CreateSecondaryReferenceProfile) {
435 EXPECT_EQ("/data/user/0/com.example/oat/secondary.dex.prof",
436 create_reference_profile_path("com.example",
437 "/data/user/0/com.example/secondary.dex", /*is_secondary*/true));
438 }
439
pass_secondary_dex_validation(const std::string & package_name,const std::string & dex_path,int uid,int storage_flag)440 static void pass_secondary_dex_validation(const std::string& package_name,
441 const std::string& dex_path, int uid, int storage_flag) {
442 EXPECT_TRUE(validate_secondary_dex_path(package_name, dex_path, /*volume_uuid*/ nullptr, uid,
443 storage_flag))
444 << dex_path << " should be allowed as a valid secondary dex path";
445 }
446
fail_secondary_dex_validation(const std::string & package_name,const std::string & dex_path,int uid,int storage_flag)447 static void fail_secondary_dex_validation(const std::string& package_name,
448 const std::string& dex_path, int uid, int storage_flag) {
449 EXPECT_FALSE(validate_secondary_dex_path(package_name, dex_path, /*volume_uuid*/ nullptr, uid,
450 storage_flag))
451 << dex_path << " should not be allowed as a valid secondary dex path";
452 }
453
TEST_F(UtilsTest,ValidateSecondaryDexFilesPath)454 TEST_F(UtilsTest, ValidateSecondaryDexFilesPath) {
455 std::string package_name = "com.test.app";
456 std::string app_dir_ce_user_0 = "/data/data/" + package_name;
457 std::string app_dir_ce_user_0_link = "/data/user/0/" + package_name;
458 std::string app_dir_ce_user_10 = "/data/user/10/" + package_name;
459
460 std::string app_dir_de_user_0 = "/data/user_de/0/" + package_name;
461 std::string app_dir_de_user_10 = "/data/user_de/10/" + package_name;
462
463 EXPECT_EQ(app_dir_ce_user_0,
464 create_data_user_ce_package_path(nullptr, 0, package_name.c_str()));
465 EXPECT_EQ(app_dir_ce_user_10,
466 create_data_user_ce_package_path(nullptr, 10, package_name.c_str()));
467
468 EXPECT_EQ(app_dir_de_user_0,
469 create_data_user_de_package_path(nullptr, 0, package_name.c_str()));
470 EXPECT_EQ(app_dir_de_user_10,
471 create_data_user_de_package_path(nullptr, 10, package_name.c_str()));
472
473 uid_t app_uid_for_user_0 = multiuser_get_uid(/*user_id*/0, /*app_id*/ 1234);
474 uid_t app_uid_for_user_10 = multiuser_get_uid(/*user_id*/10, /*app_id*/ 1234);
475
476 // Standard path for user 0 on CE storage.
477 pass_secondary_dex_validation(
478 package_name, app_dir_ce_user_0 + "/ce0.dex", app_uid_for_user_0, FLAG_STORAGE_CE);
479 pass_secondary_dex_validation(
480 package_name, app_dir_ce_user_0_link + "/ce0.dex", app_uid_for_user_0, FLAG_STORAGE_CE);
481 // Standard path for user 10 on CE storage.
482 pass_secondary_dex_validation(
483 package_name, app_dir_ce_user_10 + "/ce10.dex", app_uid_for_user_10, FLAG_STORAGE_CE);
484
485 // Standard path for user 0 on DE storage.
486 pass_secondary_dex_validation(
487 package_name, app_dir_de_user_0 + "/de0.dex", app_uid_for_user_0, FLAG_STORAGE_DE);
488 // Standard path for user 10 on DE storage.
489 pass_secondary_dex_validation(
490 package_name, app_dir_de_user_10 + "/de0.dex", app_uid_for_user_10, FLAG_STORAGE_DE);
491
492 // Dex path for user 0 accessed from user 10.
493 fail_secondary_dex_validation(
494 package_name, app_dir_ce_user_0 + "/path0_from10.dex",
495 app_uid_for_user_10, FLAG_STORAGE_CE);
496
497 // Dex path for CE storage accessed with DE.
498 fail_secondary_dex_validation(
499 package_name, app_dir_ce_user_0 + "/ce_from_de.dex", app_uid_for_user_0, FLAG_STORAGE_DE);
500
501 // Dex path for DE storage accessed with CE.
502 fail_secondary_dex_validation(
503 package_name, app_dir_de_user_0 + "/de_from_ce.dex", app_uid_for_user_0, FLAG_STORAGE_CE);
504
505 // Location which does not start with '/'.
506 fail_secondary_dex_validation(
507 package_name, "without_slash.dex", app_uid_for_user_10, FLAG_STORAGE_DE);
508
509 // The dex file is not in the specified package directory.
510 fail_secondary_dex_validation(
511 "another.package", app_dir_ce_user_0 + "/for_another_package.dex",
512 app_uid_for_user_0, FLAG_STORAGE_DE);
513
514 // The dex path contains indirect directories.
515 fail_secondary_dex_validation(
516 package_name, app_dir_ce_user_0 + "/1/../foo.dex", app_uid_for_user_0, FLAG_STORAGE_CE);
517 fail_secondary_dex_validation(
518 package_name, app_dir_ce_user_0 + "/1/./foo.dex", app_uid_for_user_0, FLAG_STORAGE_CE);
519
520 // Super long path.
521 std::string too_long = create_too_long_path("too_long_");
522 fail_secondary_dex_validation(
523 package_name, app_dir_ce_user_10 + "/" + too_long, app_uid_for_user_10, FLAG_STORAGE_CE);
524 }
525
TEST_F(UtilsTest,ValidateApkPath)526 TEST_F(UtilsTest, ValidateApkPath) {
527 EXPECT_EQ(0, validate_apk_path("/data/app/com.example"));
528 EXPECT_EQ(0, validate_apk_path("/data/app/com.example/file"));
529 EXPECT_EQ(0, validate_apk_path("/data/app/com.example//file"));
530 EXPECT_EQ(0, validate_apk_path("/data/app/random/com.example/"));
531 EXPECT_EQ(0, validate_apk_path("/data/app/random/com.example/file"));
532 EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/file"));
533 EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir//file"));
534 EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/dir/file"));
535 EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/dir//file"));
536 }
537
TEST_F(UtilsTest,ValidateApkPathSubdirs)538 TEST_F(UtilsTest, ValidateApkPathSubdirs) {
539 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example"));
540 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/file"));
541 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example//file"));
542 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/"));
543 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/file"));
544 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/file"));
545 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir//file"));
546 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir/file"));
547 EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir//file"));
548 EXPECT_NE(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir/dir/file"));
549 EXPECT_NE(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir/dir//file"));
550 }
551
TEST_F(UtilsTest,MatchExtension_Valid)552 TEST_F(UtilsTest, MatchExtension_Valid) {
553 EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("mpg"));
554 EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("mpeg"));
555 EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("mPeG"));
556 EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("MPEG"));
557 }
558
TEST_F(UtilsTest,MatchExtension_Invalid)559 TEST_F(UtilsTest, MatchExtension_Invalid) {
560 EXPECT_EQ(0, MatchExtension("log"));
561 EXPECT_EQ(0, MatchExtension("3amp"));
562 EXPECT_EQ(0, MatchExtension("fpe"));
563 EXPECT_EQ(0, MatchExtension("docx"));
564 }
565
TEST_F(UtilsTest,TestIsRenamedDeletedDir)566 TEST_F(UtilsTest, TestIsRenamedDeletedDir) {
567 EXPECT_FALSE(is_renamed_deleted_dir(""));
568 EXPECT_FALSE(is_renamed_deleted_dir("1"));
569 EXPECT_FALSE(is_renamed_deleted_dir("="));
570 EXPECT_FALSE(is_renamed_deleted_dir("=="));
571 EXPECT_FALSE(is_renamed_deleted_dir("d=="));
572 EXPECT_FALSE(is_renamed_deleted_dir("ed=="));
573 EXPECT_FALSE(is_renamed_deleted_dir("ted=="));
574 EXPECT_FALSE(is_renamed_deleted_dir("eted=="));
575 EXPECT_FALSE(is_renamed_deleted_dir("leted=="));
576 EXPECT_FALSE(is_renamed_deleted_dir("eleted=="));
577 EXPECT_FALSE(is_renamed_deleted_dir("deleted=="));
578 EXPECT_FALSE(is_renamed_deleted_dir("=deleted=="));
579 EXPECT_TRUE(is_renamed_deleted_dir("==deleted=="));
580 EXPECT_TRUE(is_renamed_deleted_dir("123==deleted=="));
581 EXPECT_TRUE(is_renamed_deleted_dir("5b14b6458a44==deleted=="));
582 }
583
TEST_F(UtilsTest,TestRollbackPaths)584 TEST_F(UtilsTest, TestRollbackPaths) {
585 EXPECT_EQ("/data/misc_ce/0/rollback/239/com.foo",
586 create_data_misc_ce_rollback_package_path(nullptr, 0, 239, "com.foo"));
587 EXPECT_EQ("/data/misc_ce/10/rollback/37/com.foo",
588 create_data_misc_ce_rollback_package_path(nullptr, 10, 37, "com.foo"));
589
590 EXPECT_EQ("/data/misc_de/0/rollback/73/com.foo",
591 create_data_misc_de_rollback_package_path(nullptr, 0, 73, "com.foo"));
592 EXPECT_EQ("/data/misc_de/10/rollback/13/com.foo",
593 create_data_misc_de_rollback_package_path(nullptr, 10, 13, "com.foo"));
594
595 EXPECT_EQ("/data/misc_ce/0/rollback/57",
596 create_data_misc_ce_rollback_path(nullptr, 0, 57));
597 EXPECT_EQ("/data/misc_ce/10/rollback/1543",
598 create_data_misc_ce_rollback_path(nullptr, 10, 1543));
599
600 EXPECT_EQ("/data/misc_de/0/rollback/43",
601 create_data_misc_de_rollback_path(nullptr, 0, 43));
602 EXPECT_EQ("/data/misc_de/10/rollback/41",
603 create_data_misc_de_rollback_path(nullptr, 10, 41));
604
605 EXPECT_EQ("/data/misc_ce/0/rollback/17/com.foo",
606 create_data_misc_ce_rollback_package_path(nullptr, 0, 17, "com.foo", 0));
607 EXPECT_EQ("/data/misc_ce/0/rollback/19/com.foo",
608 create_data_misc_ce_rollback_package_path(nullptr, 0, 19, "com.foo", 239));
609
610 auto rollback_ce_path = create_data_misc_ce_rollback_path(nullptr, 0, 53);
611 auto rollback_ce_package_path = create_data_misc_ce_rollback_package_path(nullptr, 0, 53,
612 "com.foo");
613 auto deleter = [&rollback_ce_path]() {
614 delete_dir_contents_and_dir(rollback_ce_path, true /* ignore_if_missing */);
615 };
616 auto scope_guard = android::base::make_scope_guard(deleter);
617
618 EXPECT_NE(-1, mkdir(rollback_ce_path.c_str(), 700));
619 EXPECT_NE(-1, mkdir(rollback_ce_package_path.c_str(), 700));
620
621 ino_t ce_data_inode;
622 EXPECT_EQ(0, get_path_inode(rollback_ce_package_path, &ce_data_inode));
623
624 EXPECT_EQ("/data/misc_ce/0/rollback/53/com.foo",
625 create_data_misc_ce_rollback_package_path(nullptr, 0, 53, "com.foo", ce_data_inode));
626 // Check that path defined by inode is picked even if it's not the same as
627 // the fallback one.
628 EXPECT_EQ("/data/misc_ce/0/rollback/53/com.foo",
629 create_data_misc_ce_rollback_package_path(nullptr, 0, 53, "com.bar", ce_data_inode));
630
631 // These last couple of cases are never exercised in production because we
632 // only snapshot apps in the primary data partition. Exercise them here for
633 // the sake of completeness.
634 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/misc_ce/0/rollback/7/com.example",
635 create_data_misc_ce_rollback_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0, 7,
636 "com.example"));
637 EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/misc_de/0/rollback/11/com.example",
638 create_data_misc_de_rollback_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0, 11,
639 "com.example"));
640 }
641
TEST_F(UtilsTest,TestCreateDirIfNeeded)642 TEST_F(UtilsTest, TestCreateDirIfNeeded) {
643 system("mkdir -p /data/local/tmp/user/0");
644
645 auto deleter = [&]() {
646 delete_dir_contents_and_dir("/data/local/tmp/user/0", true /* ignore_if_missing */);
647 };
648 auto scope_guard = android::base::make_scope_guard(deleter);
649
650 // Create folder and check it's permissions.
651 ASSERT_EQ(0, create_dir_if_needed("/data/local/tmp/user/0/foo", 0700));
652 struct stat st;
653 ASSERT_EQ(0, stat("/data/local/tmp/user/0/foo", &st));
654 ASSERT_EQ(0700, st.st_mode & ALLPERMS);
655
656 // Check that create_dir_if_needed is no-op if folder already exists with
657 // correct permissions.
658 ASSERT_EQ(0, create_dir_if_needed("/data/local/tmp/user/0/foo", 0700));
659
660 // Check -1 is returned if folder exists but with different permissions.
661 ASSERT_EQ(-1, create_dir_if_needed("/data/local/tmp/user/0/foo", 0750));
662
663 // Check that call fails if parent doesn't exist.
664 ASSERT_NE(0, create_dir_if_needed("/data/local/tmp/user/0/bar/baz", 0700));
665 }
666
TEST_F(UtilsTest,TestForEachSubdir)667 TEST_F(UtilsTest, TestForEachSubdir) {
668 auto deleter = [&]() {
669 delete_dir_contents_and_dir("/data/local/tmp/user/0", true /* ignore_if_missing */);
670 };
671 auto scope_guard = android::base::make_scope_guard(deleter);
672
673 system("mkdir -p /data/local/tmp/user/0/com.foo");
674 system("mkdir -p /data/local/tmp/user/0/com.bar");
675 system("touch /data/local/tmp/user/0/some-file");
676
677 std::vector<std::string> result;
678 foreach_subdir("/data/local/tmp/user/0",
679 [&](const std::string &filename) { result.push_back(filename); });
680
681 EXPECT_THAT(result, UnorderedElementsAre("com.foo", "com.bar"));
682 }
683
TEST_F(UtilsTest,TestSdkSandboxDataPaths)684 TEST_F(UtilsTest, TestSdkSandboxDataPaths) {
685 // Ce data paths
686 EXPECT_EQ("/data/misc_ce/0/sdksandbox",
687 create_data_misc_sdk_sandbox_path(nullptr, /*isCeData=*/true, 0));
688 EXPECT_EQ("/data/misc_ce/10/sdksandbox", create_data_misc_sdk_sandbox_path(nullptr, true, 10));
689
690 EXPECT_EQ("/data/misc_ce/0/sdksandbox/com.foo",
691 create_data_misc_sdk_sandbox_package_path(nullptr, true, 0, "com.foo"));
692 EXPECT_EQ("/data/misc_ce/10/sdksandbox/com.foo",
693 create_data_misc_sdk_sandbox_package_path(nullptr, true, 10, "com.foo"));
694
695 EXPECT_EQ("/data/misc_ce/0/sdksandbox/com.foo/shared",
696 create_data_misc_sdk_sandbox_sdk_path(nullptr, true, 0, "com.foo", "shared"));
697 EXPECT_EQ("/data/misc_ce/10/sdksandbox/com.foo/shared",
698 create_data_misc_sdk_sandbox_sdk_path(nullptr, true, 10, "com.foo", "shared"));
699 EXPECT_EQ("/data/misc_ce/10/sdksandbox/com.foo/bar@random",
700 create_data_misc_sdk_sandbox_sdk_path(nullptr, true, 10, "com.foo", "bar@random"));
701
702 // De data paths
703 EXPECT_EQ("/data/misc_de/0/sdksandbox",
704 create_data_misc_sdk_sandbox_path(nullptr, /*isCeData=*/false, 0));
705 EXPECT_EQ("/data/misc_de/10/sdksandbox", create_data_misc_sdk_sandbox_path(nullptr, false, 10));
706
707 EXPECT_EQ("/data/misc_de/0/sdksandbox/com.foo",
708 create_data_misc_sdk_sandbox_package_path(nullptr, false, 0, "com.foo"));
709 EXPECT_EQ("/data/misc_de/10/sdksandbox/com.foo",
710 create_data_misc_sdk_sandbox_package_path(nullptr, false, 10, "com.foo"));
711
712 EXPECT_EQ("/data/misc_de/0/sdksandbox/com.foo/shared",
713 create_data_misc_sdk_sandbox_sdk_path(nullptr, false, 0, "com.foo", "shared"));
714 EXPECT_EQ("/data/misc_de/10/sdksandbox/com.foo/shared",
715 create_data_misc_sdk_sandbox_sdk_path(nullptr, false, 10, "com.foo", "shared"));
716 EXPECT_EQ("/data/misc_de/10/sdksandbox/com.foo/bar@random",
717 create_data_misc_sdk_sandbox_sdk_path(nullptr, false, 10, "com.foo", "bar@random"));
718 }
719
TEST_F(UtilsTest,WaitChild)720 TEST_F(UtilsTest, WaitChild) {
721 pid_t pid = fork();
722 if (pid == 0) {
723 /* child */
724 // Do nothing.
725 _exit(0);
726 }
727 /* parent */
728 int return_code = wait_child_with_timeout(pid, /*timeout_ms=*/100);
729 EXPECT_TRUE(WIFEXITED(return_code));
730 EXPECT_EQ(WEXITSTATUS(return_code), 0);
731 }
732
TEST_F(UtilsTest,WaitChildTimeout)733 TEST_F(UtilsTest, WaitChildTimeout) {
734 pid_t pid = fork();
735 if (pid == 0) {
736 /* child */
737 sleep(1);
738 _exit(0);
739 }
740 /* parent */
741 int return_code = wait_child_with_timeout(pid, /*timeout_ms=*/1);
742 EXPECT_FALSE(WIFEXITED(return_code));
743 EXPECT_EQ(WTERMSIG(return_code), SIGKILL);
744 }
745
TEST_F(UtilsTest,RemoveFileAtFd)746 TEST_F(UtilsTest, RemoveFileAtFd) {
747 std::string filename = "/data/local/tmp/tempfile-XXXXXX";
748 int fd = mkstemp(filename.data());
749 ASSERT_GE(fd, 0);
750 ASSERT_EQ(access(filename.c_str(), F_OK), 0);
751
752 std::string actual_filename;
753 remove_file_at_fd(fd, &actual_filename);
754 EXPECT_NE(access(filename.c_str(), F_OK), 0);
755 EXPECT_EQ(filename, actual_filename);
756
757 close(fd);
758 }
759
760 } // namespace installd
761 } // namespace android
762